feat: add support for multiple forward and http in globaInputs#1867
Open
ben-dov wants to merge 5 commits intofluent:masterfrom
Open
feat: add support for multiple forward and http in globaInputs#1867ben-dov wants to merge 5 commits intofluent:masterfrom
ben-dov wants to merge 5 commits intofluent:masterfrom
Conversation
Collaborator
|
@ben-dov Thanks for the PR! Would you please add some tests for this functionality? I realize tests didn't exist prior to this PR, but we're trying to improve our testing coverage. |
Contributor
Author
|
hey @joshuabaird, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are cases were we would like to add several forward or http global inputs to the same fluent deployment.
for example, separate processing logic depending on tag prefix.
Which issue(s) this PR fixes:
Fixes #1833
Does this PR introduced a user-facing change?
Additional information
The PR does not include an breaking changes, since the first iteration of forward/http port name stays the same in the container and service of fluentd. The code can be further simplified by removing the backward compatibility logic.