feat(fluentbit): adds support for workers to syslog output#1874
Open
mob-galtryn wants to merge 1 commit intofluent:masterfrom
Open
feat(fluentbit): adds support for workers to syslog output#1874mob-galtryn wants to merge 1 commit intofluent:masterfrom
mob-galtryn wants to merge 1 commit intofluent:masterfrom
Conversation
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
joshuabaird
reviewed
Feb 17, 2026
| plugins.InsertKVString(kvs, "syslog_sd_key", s.SyslogSDKey) | ||
| plugins.InsertKVString(kvs, "storage.total_limit_size", s.TotalLimitSize) | ||
| plugins.InsertKVField(kvs, "syslog_maxsize", s.SyslogMaxSize) | ||
| plugins.InsertKVField(kvs, "Workers", s.Workers) |
Collaborator
There was a problem hiding this comment.
Param name (workers) should be lowercase.
Collaborator
|
@mob-galtryn Would you mind taking a look at tests for other output plugins (eg, datadog, gelf, s3) and implement tests for the syslog output plugin in a similar fashion? Thanks! |
Author
|
@joshuabaird I have found tests here apis/fluentbit/v1alpha2/clusteroutput_types_test.go that includes tests for the syslog output, are these the tests you are referring to? |
joshuabaird
changed the title
joshuabaird
changed the title
Collaborator
Tests would probably go in a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Galtry nick.galtry@mobilise.cloud
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1870
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: