fix: escape footnote tooltip content in aria-label#1238
Merged
zkqiang merged 1 commit intofluid-dev:developfrom Mar 9, 2026
Merged
fix: escape footnote tooltip content in aria-label#1238zkqiang merged 1 commit intofluid-dev:developfrom
zkqiang merged 1 commit intofluid-dev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labelProblem
The footnote tooltip renderer currently does
stripHTML()and then injects the result directly into:If the footnote content contains quotes, the generated
aria-labelcan break and the hover span markup may be rendered as visible text instead of a tooltip.Reproduction
A footnote like this is enough to trigger it:
Fix
Apply HTML attribute escaping to the stripped footnote text before concatenating it into
aria-label.Validation
<span class=...>text appears in the page body