fix: clipboard copy on non-secure context#1560
Merged
pedrolamas merged 1 commit intofluidd-core:developfrom Dec 29, 2024
Merged
fix: clipboard copy on non-secure context#1560pedrolamas merged 1 commit intofluidd-core:developfrom
pedrolamas merged 1 commit intofluidd-core:developfrom
Conversation
pedrolamas
force-pushed
the
pedrolamas/fix-1556
branch
from
11dcecb to
e56925d
Compare
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
force-pushed
the
pedrolamas/fix-1556
branch
from
e56925d to
3bda1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing clipboard copy method relies on having
navigator.clipboardaccess, however this is only available on "secure" https context, and alwaysundefinedon "non-secure" http context.The fix here is to use an old deprecated method that seems to still work in browsers and under "non-secure" http context.
Fix #1556