feat(Happy Hare): Adds new flowguard meter for monitoring clog and tangles#1759
feat(Happy Hare): Adds new flowguard meter for monitoring clog and tangles#1759pedrolamas merged 14 commits intofluidd-core:developfrom
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com> # Conflicts: # src/store/printer/types.ts
…tion into flowguard
|
I'm very sorry. I realized a small bug in the "display meter" condition so pushed a fix. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
| get hasSyncFeedback (): boolean { | ||
| return this.hasFilamentCompressionSensor || this.hasFilamentTensionSensor || this.hasFilamentProportionalSensor | ||
| } | ||
|
|
||
| get hasFilamentProportionalSensor (): boolean { | ||
| return this.hasSensor('filament_proportional') | ||
| } | ||
|
|
||
| get hasFilamentCompressionSensor (): boolean { | ||
| return this.hasSensor('filament_compression') | ||
| } | ||
|
|
||
| get hasFilamentTensionSensor (): boolean { | ||
| return this.hasSensor('filament_tension') | ||
| } | ||
|
|
||
| private hasSensor (sensorName: string): boolean { | ||
| return sensorName in this.sensors | ||
| } |
There was a problem hiding this comment.
Duplicate code: The methods hasSyncFeedback, hasFilamentProportionalSensor, hasFilamentCompressionSensor, hasFilamentTensionSensor, and hasSensor are duplicated in both MmuCard.vue and MmuSettings.vue. Consider moving these shared methods to the MmuMixin or creating a separate utility function to avoid code duplication.
| get hasSyncFeedback (): boolean { | |
| return this.hasFilamentCompressionSensor || this.hasFilamentTensionSensor || this.hasFilamentProportionalSensor | |
| } | |
| get hasFilamentProportionalSensor (): boolean { | |
| return this.hasSensor('filament_proportional') | |
| } | |
| get hasFilamentCompressionSensor (): boolean { | |
| return this.hasSensor('filament_compression') | |
| } | |
| get hasFilamentTensionSensor (): boolean { | |
| return this.hasSensor('filament_tension') | |
| } | |
| private hasSensor (sensorName: string): boolean { | |
| return sensorName in this.sensors | |
| } |
There was a problem hiding this comment.
@moggieuk not sure if these are all the same, but kinda makes sense to me as I see some of these appearing in 3 places... what do you think?
There was a problem hiding this comment.
There are indeed the same and could be moved to mmu.ts mixin. I actually deliberately duplicated to make each PR clean and merge in any order.
Would you like me to move to the mmu mixin?
There was a problem hiding this comment.
Happy to leave as is and you can refactor separately if that makes sense.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
2 participants
Description:
This adds a "FlowGuard" meter to replace or compliment the encoder clog meter. It uses the sync-feedback buffer input and controller in Happy Hare to offer feedback and prediction of clogs and tangles.
Shown here on printer with MMU with encoder and sync-feedback buffer. If only one or the other sensor is present, only the respective meter is available/shown.
SIgned off by: Paul Morgan (moggieuk@hotmail.com)