Skip to content

feat: show full timestamp tooltip on relative #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrolamas merged 1 commit into from
Dec 29, 2025
Merged

feat: show full timestamp tooltip on relative #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/components/layout/AppNotificationMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,18 @@
v-safe-html="n.description"
class="notification-description"
/>
<v-list-item-subtitle class="notification-timestamp">
{{ $filters.formatRelativeTimeToNow(n.timestamp * 1000) }}
</v-list-item-subtitle>
<v-tooltip bottom>
<template #activator="{ on, attrs }">
<v-list-item-subtitle
v-bind="attrs"
class="notification-timestamp"
v-on="on"
Comment on lines +89 to +90
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directive order should be consistent with the rest of the codebase. Place v-bind before class and v-on after all other directives. The standard pattern in this codebase is: v-bind, other directives/attributes, then v-on at the end.

Suggested change
class="notification-timestamp"
v-on="on"
v-on="on"
class="notification-timestamp"

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@pedrolamas pedrolamas Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what it is.... Copilot, are you drunk??

>
{{ $filters.formatRelativeTimeToNow(n.timestamp * 1000) }}
</v-list-item-subtitle>
</template>
<span>{{ $filters.formatDateTime(n.timestamp * 1000) }}</span>
</v-tooltip>
<v-list-item-subtitle v-if="n.to">
<app-btn
v-if="!n.to.startsWith('http')"
Expand Down
12 changes: 11 additions & 1 deletion src/components/settings/VersionInformationDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,17 @@
>
<strong>{{ commit.author }}</strong>
</a>
{{ $t('app.version.label.committed') }} {{ $filters.formatRelativeTimeToNow(+commit.date * 1000) }}
<v-tooltip bottom>
<template #activator="{ on, attrs }">
<span
v-bind="attrs"
v-on="on"
>
{{ $t('app.version.label.committed') }} {{ $filters.formatRelativeTimeToNow(+commit.date * 1000) }}
</span>
</template>
<span>{{ $filters.formatDateTime(+commit.date * 1000) }}</span>
</v-tooltip>
</div>
</div>
<div>
Expand Down