Skip to content

Conversation

@rmedina97
Copy link
Collaborator

@rmedina97 rmedina97 commented May 6, 2025

Hi!

With this PR, I refactored the installation guides by removing the old one and integrating its relevant parts into the current documentation.

Changes:

  1. tools/script/requirements.sh

    • Fixed liqoctl installation by removing the logic for unstable versions.
    • Created the checks_kind function and added it to checks_tools.
    • Added automatic Docker installation.
    • Pinned tool versions: kubectl (v1.33), kind (v0.27), and Docker (stable).
  2. Removed the testbed folder (previous location of the old guide):

    • The consumer, provider, and metric server yaml files were already available in the quickstart folder, which are the ones referenced by the new guide.
  3. docs/installation/installation.md

    • Added content from the old guide under the "Testbed Installation" section.
    • Introduced new sections: Prerequisites, Common issues with kind, and Usage.
    • In the Manual Installation section, fixed:
      • Link to Liqo,
      • Path to consumer-values.yaml,
      • Added description of the install_liqo.sh usage.
  4. tools/script/install_liqo.sh

    • Added parameter checks.
  5. tools/script/environment.sh

    • Removed architecture-specific dependencies in the Macvlan plugin installation link.

Thanks in advance for your feedback!

@rmedina97 rmedina97 marked this pull request as ready for review May 7, 2025 07:44
Copy link
Contributor

@LorenzoMoro LorenzoMoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmedina97 rmedina97 force-pushed the fix/requirements-script branch 3 times, most recently from 4602803 to b6b7cc1 Compare May 13, 2025 07:58
Copy link
Contributor

@LorenzoMoro LorenzoMoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note

@LorenzoMoro LorenzoMoro force-pushed the fix/requirements-script branch from 1fc99e2 to f44a9c6 Compare May 18, 2025 17:59
@rmedina97 rmedina97 merged commit 9018b69 into main May 18, 2025
6 checks passed
@rmedina97 rmedina97 deleted the fix/requirements-script branch May 18, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants