fix: change initCustomerSheet return type to Future<void> #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, I submitted this PR on Dec 20 to fix issue #2283. PR #2292 (submitted Dec 27) has an identical title and the same logic changes, and a reviewer has been assigned to it. Could you please let me know if there's something I should improve in this PR? I'd be happy to address any feedback. Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #2283
Changes
Changed return type from
Future<CustomerSheetResult?>toFuture<void>to match actual behavior and align with React Native SDK.The method always returned
nullon success:[]The type
CustomerSheetResult?was misleading. This fixes the type definition to match reality.If there was an intentional reason for the
CustomerSheetResult?return type that I may have missed, I'd appreciate any insights. I want to ensure this change aligns with the package's design goals.