Skip to content

Makes 'unexpected engineArtifacts' an error. #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Apr 15, 2025
Merged

Makes 'unexpected engineArtifacts' an error. #4515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app_dart/lib/src/service/luci_build_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,8 @@ class LuciBuildService {
}
} else if (engineArtifacts is! UnnecessaryEngineArtifacts) {
// This is an error case, as we're setting artifacts for a PR that will never use them.
log.warn(
throw StateError(
'Unexpected engineArtifacts were specified for PR#${pullRequest.number} (${pullRequest.head!.sha})',
null,
StackTrace.current,
);
}

Expand Down
4 changes: 2 additions & 2 deletions app_dart/test/service/luci_build_service/schedule_try_builds_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,8 @@ void main() {
await luci.scheduleTryBuilds(
pullRequest: pullRequest,
targets: [buildTarget],
engineArtifacts: EngineArtifacts.usingExistingEngine(
commitSha: pullRequest.base!.sha!,
engineArtifacts: const EngineArtifacts.noFrameworkTests(
reason: 'Not a flutter/flutter PR',
),
);

Expand Down