[CQ] Unnecessary code cleanup (#8080)

Addressed/removed unnecessary code in the form of:

* redundant suppressions
* redundant throws
* redundant casts
* unused imports
* redundant `toString()`, `substring(..)` calls
* unnecessary `default` branches
* explicit types where `<>` will do
* stream API call chains where `toList()` is enough

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md

Author: pq

Diff for: flutter-idea/src/io/flutter/actions/FlutterBuildActionGroup.java

@@ -47,11 +47,9 @@ public void processTerminated(@NotNull ProcessEvent event) {
     };
     final Module module = pubRoot.getModule(project);
     if (module != null) {
-      //noinspection ConstantConditions
       sdk.flutterBuild(pubRoot, buildType.type).startInModuleConsole(module, pubRoot::refresh, processAdapter);
     }
     else {
-      //noinspection ConstantConditions
       final ColoredProcessHandler processHandler = sdk.flutterBuild(pubRoot, buildType.type).startInConsole(project);
       if (processHandler == null) {
         progressHelper.done();

Diff for: flutter-idea/src/io/flutter/devtools/DevToolsUtils.java

@@ -15,8 +15,6 @@
 import org.dartlang.vm.service.VmServiceListener;
 import org.jetbrains.annotations.NotNull;
 
-import org.dartlang.vm.service.element.Event;
-
 import com.google.gson.JsonObject;
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.vfs.LocalFileSystem;

Diff for: flutter-idea/src/io/flutter/editor/ActiveEditorsOutlineService.java

@@ -95,7 +95,7 @@ public List<EditorEx> getActiveDartEditors() {
     for (FileEditor fileEditor : editors) {
       if (!(fileEditor instanceof TextEditor textEditor)) continue;
       final Editor editor = textEditor.getEditor();
-      if (editor instanceof EditorEx && !editor.isDisposed() && FlutterUtils.isDartFile(((EditorEx)editor).getVirtualFile())) {
+      if (editor instanceof EditorEx && !editor.isDisposed() && FlutterUtils.isDartFile(editor.getVirtualFile())) {
         dartEditors.add((EditorEx)editor);
       }
     }

Diff for: flutter-idea/src/io/flutter/font/FontPreviewProcessor.java

@@ -576,7 +576,7 @@ public void addClasses(@NotNull String packageName, @NotNull String filePath, @N
       classesToAnalyze.addAll(
         names.stream()
           .map((each) -> new ClassInfo(packageName, filePath, each))
-          .collect(Collectors.toList()));
+          .toList());
     }
 
     void addFilesToRewrite(@NotNull String packageName, @NotNull Collection<VirtualFile> files) {
@@ -588,7 +588,7 @@ void addFilesToRewrite(@NotNull String packageName, @NotNull Collection<VirtualF
             return !(packageIndex < 0 || isInSdk(path));
           })
           .map((each) -> new FileInfo(packageName, each.getPath(), each))
-          .collect(Collectors.toList()));
+          .toList());
     }
   }
 

Diff for: flutter-idea/src/io/flutter/jxbrowser/EmbeddedJxBrowser.java

@@ -219,7 +219,6 @@ public Logger logger() {
       case MISSING_PLATFORM_FILES -> "JX Browser platform files are missing";
       case CLASS_LOAD_FAILED -> "JX Browser class load failed";
       case CLASS_NOT_FOUND -> "JX Browser class not found";
-      default -> null;
     };
 
   }

Diff for: flutter-idea/src/io/flutter/run/FlutterConfigurationEditorForm.java

@@ -43,7 +43,7 @@ protected void resetEditorFrom(@NotNull final SdkRunConfig config) {
   }
 
   @Override
-  protected void applyEditorTo(@NotNull final SdkRunConfig config) throws ConfigurationException {
+  protected void applyEditorTo(@NotNull final SdkRunConfig config) {
     final SdkFields fields = new SdkFields();
     fields.setFilePath(StringUtil.nullize(FileUtil.toSystemIndependentName(myFileField.getText().trim()), true));
     fields.setBuildFlavor(StringUtil.nullize(myBuildFlavorField.getText().trim()));

Diff for: flutter-idea/src/io/flutter/run/FlutterReloadManager.java

@@ -234,7 +234,7 @@ private void handleSaveAllNotification(@Nullable Editor editor) {
     if (file == null) {
       return;
     }
-    if (file.getPath().startsWith(configPath.toString())) {
+    if (file.getPath().startsWith(configPath)) {
       return; // Ignore changes to scratch files.
     }
     if (System.currentTimeMillis() - file.getTimeStamp() > 500) {

Diff for: flutter-idea/src/io/flutter/run/bazel/FlutterBazelConfigurationEditorForm.java

@@ -43,7 +43,7 @@ protected void resetEditorFrom(@NotNull final BazelRunConfig configuration) {
   }
 
   @Override
-  protected void applyEditorTo(@NotNull final BazelRunConfig configuration) throws ConfigurationException {
+  protected void applyEditorTo(@NotNull final BazelRunConfig configuration) {
     String target = myTarget.getText().trim();
     final BazelFields fields = new BazelFields(
       StringUtil.nullize(target.endsWith("dart") ? FileUtil.toSystemIndependentName(target) : target, true),

Diff for: flutter-idea/src/io/flutter/run/coverage/FlutterCoverageProgramRunner.java

@@ -62,7 +62,7 @@ public RunnerSettings createConfigurationData(@NotNull final ConfigurationInfoPr
   @Override
   @Nullable
   protected RunContentDescriptor doExecute(final @NotNull RunProfileState state,
-                                           final @NotNull ExecutionEnvironment env) throws ExecutionException {
+                                           final @NotNull ExecutionEnvironment env) {
     final RunContentDescriptor result = DefaultProgramRunnerKt.executeState(state, env, this);
     if (result == null) {
       return null;

Diff for: flutter-idea/src/io/flutter/run/test/TestForm.java

@@ -9,7 +9,6 @@
 import com.intellij.openapi.options.ConfigurationException;
 import com.intellij.openapi.options.SettingsEditor;
 import com.intellij.openapi.project.Project;
-import com.intellij.openapi.ui.TextComponentAccessor;
 import com.intellij.openapi.ui.TextFieldWithBrowseButton;
 import com.intellij.ui.ListCellRendererWrapper;
 import io.flutter.run.test.TestFields.Scope;
@@ -96,12 +95,11 @@ protected void resetEditorFrom(@NotNull TestConfig config) {
   }
 
   @Override
-  protected void applyEditorTo(@NotNull TestConfig config) throws ConfigurationException {
+  protected void applyEditorTo(@NotNull TestConfig config) {
     final TestFields fields = switch (getScope()) {
       case NAME -> TestFields.forTestName(testName.getText(), testFile.getText());
       case FILE -> TestFields.forFile(testFile.getText());
       case DIRECTORY -> TestFields.forDir(testDir.getText());
-      default -> throw new ConfigurationException("unexpected scope: " + scope.getSelectedItem());
     };
     fields.setAdditionalArgs(additionalArgs.getText().trim());
     config.setFields(fields);

Diff for: flutter-idea/src/io/flutter/view/EmbeddedJcefBrowser.java

@@ -19,7 +19,7 @@
 class EmbeddedJcefBrowserTab implements EmbeddedTab {
   private JBCefBrowser browser;
 
-  public EmbeddedJcefBrowserTab() throws Exception {
+  public EmbeddedJcefBrowserTab() {
     this.browser = new JBCefBrowser();
   }
 

Diff for: flutter-idea/testSrc/unit/io/flutter/testing/JsonTesting.java

@@ -25,7 +25,7 @@ public static String curly(String... pairs) {
     for (String pair : pairs) {
       final int colon = pair.indexOf(":");
       if (!first) out.append(",");
-      out.append('"').append(pair.substring(0, colon)).append("\":").append(pair.substring(colon + 1));
+      out.append('"').append(pair, 0, colon).append("\":").append(pair.substring(colon + 1));
       first = false;
     }
     out.append('}');

Diff for: flutter-studio/src/io/flutter/android/AndroidModuleLibraryType.java

@@ -22,7 +22,7 @@ public class AndroidModuleLibraryType extends LibraryType<AndroidModuleLibraryPr
   public static final String LIBRARY_NAME = "Android Libraries";
 
   public static final PersistentLibraryKind<AndroidModuleLibraryProperties> LIBRARY_KIND =
-    new PersistentLibraryKind<AndroidModuleLibraryProperties>("AndroidModuleLibraryType") {
+    new PersistentLibraryKind<>("AndroidModuleLibraryType") {
       @Override
       @NotNull
       public AndroidModuleLibraryProperties createDefaultProperties() {