Add an optional dependency on the Gemini Code Assist IJ plugin #7964
Conversation
| @@ -90,6 +90,7 @@ dependencies { | |||
| "org.jetbrains.kotlin", | |||
| "org.jetbrains.plugins.gradle", | |||
| "org.intellij.intelliLang", | |||
| "com.google.tools.ij.aiplugin", | |||
There was a problem hiding this comment.
should this be in the next if statement, only if the product is android studio?
There was a problem hiding this comment.
If we can provide the support to all users without additional work we should. It may be the case that some support is added through here, and other support will be AS specific.
| @@ -70,6 +70,7 @@ dependencies { | |||
| "org.jetbrains.kotlin", | |||
| "org.jetbrains.plugins.gradle", | |||
| "org.intellij.intelliLang", | |||
| "com.google.tools.ij.aiplugin", | |||
build.gradle.kts
Outdated
| @@ -91,6 +91,10 @@ dependencies { | |||
| "org.jetbrains.plugins.gradle", | |||
| "org.intellij.intelliLang", | |||
| ) | |||
| // The "com.google.tools.ij.aiplugin" is not avaliable for 2023.3: | |||
| if (!ideaVersion.startsWith("2024.3")) { | |||
There was a problem hiding this comment.
this seems fragile. What if the user is on 2024.4 or if we want to support this for versions greater than 2024.3 in the future? Can we add some logic to parse the version so that we can do a >= check instead?
There was a problem hiding this comment.
Idk if this version is following semver strictly, but in case it is useful, here is the dart code we use to parse semantic versions and compare them in DevTools: https://github.com/flutter/devtools/blob/master/packages/devtools_shared/lib/src/utils/semantic_version.dart/#L10
There was a problem hiding this comment.
This was supposed to be 2023.3.... We have logic in our Java code, this is in the Kotlin code, which is not a full-fledged setup for Kotlin either. I was just going back and forth with @mossmana, given the age of `2023.3, we are removing it so that when the next version of the Flutter IJ plugin has any features added in this space
Support for `2023.3` is removed with this change
No description provided.