[webview_flutter] Platform implementations for getCookies #11037 by khaled-0 · Pull Request #11386 · flutter/packages

khaled-0 · 2026-03-30T06:53:14Z

List which issues are fixed by this PR. You must list at least one issue.
#10833 #11037

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…ookies

Caveats: Domain name can not be null

swift-format reformatted the entire HTTPCookieStoreProxyAPITests.swift

GCC_TREAT_WARNINGS_AS_ERRORS = YES (no-shit)

…r.getCookies instead of document.cookie

…nsistent across platforms

…tter_platform_interface 2.14.0 -> 2.15.1

…ns & mocks

https://github.com/flutter/packages/pull/10833/changes/BASE..b38e3e7f019db61218e4233906a4060ba9ca738b#r2838733074

gemini-code-assist

Code Review

This pull request implements the getCookies method for PlatformWebViewCookieManager in both the Android and WKWebView packages. The changes include updated Pigeon definitions, native implementations for cookie retrieval, and updates to the example application to utilize the new API. Feedback identifies a bug in Android cookie parsing when values contain equals signs, incorrect domain matching logic in the WKWebView implementation that violates RFC 6265, and a missing nullability annotation in the Android native code. Typographical errors in the changelogs were also noted.

gemini-code-assist · 2026-03-30T06:55:11Z

+      final List<String> cookieValue = cookie.split('=');
+      webViewCookies.add(
+        WebViewCookie(
+          name: cookieValue.first,
+          value: cookieValue.last,
+          domain: url.toString(),
+        ),
+      );


The current cookie parsing logic is incorrect if a cookie's value contains an equals sign (=). Using cookie.split('=') and taking cookieValue.last will only capture the part of the value after the last =.

To correctly parse the cookie, you should take everything after the first = as the value.

Suggested change

final List<String> cookieValue = cookie.split('=');

webViewCookies.add(

WebViewCookie(

name: cookieValue.first,

value: cookieValue.last,

domain: url.toString(),

),

);

final List<String> cookieParts = cookie.split('=');

webViewCookies.add(

WebViewCookie(

name: cookieParts.first,

value: cookieParts.skip(1).join('='),

domain: url.toString(),

),

);

…d changelog

…` domain matching

LongCatIsLooong

The webkit implementation LGTM with a few nits / questions

LongCatIsLooong · 2026-03-31T19:16:41Z

+    final Uri? domain = Uri.tryParse(
+      (await webViewController.currentUrl()) ?? '',
+    );
+    late final List<WebViewCookie> cookies;


Nit: Is the late necessary?

apparently it's not.

LongCatIsLooong · 2026-04-10T21:17:11Z

    }

-    return Dictionary(uniqueKeysWithValues: keyValueTuples)
+    // Use newest value in case of duplicates


Why is this change needed? The original collection was a Dictionary so there won't be duplicated keys unless the code above mapped different keys to the same key (it seems to be possible with the default case, but do we care about the .unknown key?)

Why is this change needed? The original collection was a Dictionary so there won't be duplicated keys unless the code above mapped different keys to the same key (it seems to be possible with the default case, but do we care about the .unknown key?)

we don't care but swift crashes when it encounters duplicate keys
Swift/NativeDictionary.swift:792: Fatal error: Duplicate values for key: 'unknown'

LongCatIsLooong · 2026-04-10T23:42:23Z

+        cookieDomain = cookieDomain.substring(1);
+      }
+
+      if (url.host != cookieDomain && !url.host.endsWith('.$cookieDomain')) {


The API documentation says

If the domain does not start with a dot, then the cookie is only sent to the exact host specified by the domain. If the domain does start with a dot, then the cookie is sent to other hosts in that domain as well, subject to certain restrictions. See RFC 6265 for more detail.

It looks like the implementation treats both cases as the wildcard case (as if there was always a leading .)?

Because that's how WebKit behaves too

Interesting. So the API documentation is wrong / outdated. Thank you for verifying this!

…TPCookieStoreProxyAPITests. Remove unnecessary late in _onListCookies

mboetger

LGTM for Android

flutter-dashboard · 2026-04-14T17:58:15Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

camsim99 · 2026-04-14T20:55:42Z

@khaled-0 Can you rebase onto main and resolve the merge conflicts so that we can take a look? Thanks!

khaled-0 · 2026-04-14T21:34:51Z

@khaled-0 Can you rebase onto main and resolve the merge conflicts so that we can take a look? Thanks!

done. please have a look

bparrishMines

LGTM

I went ahead and merged in main and handled the conflicts. Sorry for the delay.

…r#185897) flutter/packages@cde5b36...daf30f8 2026-04-30 mdebbar@google.com [url_launcher_web] Re-enable flaky test (not flaky anymore) (flutter/packages#11478) 2026-04-30 stuartmorgan@google.com [in_app_purchase] Switch to Kotlin Pigeon (flutter/packages#11608) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] Fix mouse event loop when calling setState in TableSpan.onEnter (flutter/packages#11606) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] trailing pinned row/col for TableView (flutter/packages#11519) 2026-04-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate` (flutter/packages#11567) 2026-04-29 stuartmorgan@google.com [google_maps_flutter] Replace use of zIndex in examples and tests (flutter/packages#11572) 2026-04-29 stuartmorgan@google.com [tool] Remove --against-pub flag (flutter/packages#11550) 2026-04-29 47866232+chunhtai@users.noreply.github.com [ci] Update branch management for batch release (flutter/packages#11575) 2026-04-29 spkhalad@gmail.com [webview_flutter] Platform implementations for getCookies flutter#11037 (flutter/packages#11386) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

khaled-0 added 13 commits March 30, 2026 10:48

[webview_flutter_wkwebview] Implement getCookies method to retrieve c…

9b66f6c

…ookies

[webview_flutter_android] Implement getCookies method

4f2f4e8

Caveats: Domain name can not be null

[webview_flutter_android] test for getCookies

150d9cc

[webview_flutter_wkwebview] test for getCookies

b5f94a5

swift-format reformatted the entire HTTPCookieStoreProxyAPITests.swift

[webview_flutter_wkwebview] match getAllCookies function signature

2d5a916

GCC_TREAT_WARNINGS_AS_ERRORS = YES (no-shit)

[webview_flutter_wkwebview] Refactor getCookies to use if let

0cd5df3

[webview_flutter_android][webview_flutter_wkwebview] Use CookieManage…

092db6e

…r.getCookies instead of document.cookie

[webview_flutter_android][webview_flutter_wkwebview] make api more co…

45fa55f

…nsistent across platforms

[webview_flutter_android][webview_flutter_wkwebview] Bump webview_flu…

0f9fc43

…tter_platform_interface 2.14.0 -> 2.15.1

[webview_flutter_android][webview_flutter_wkwebview] Regenerate pigeo…

8fcd044

…ns & mocks

[webview_flutter_wkwebview] Update getCookies test to use getAllCookies

d60c7b1

[webview_flutter_android][webview_flutter_wkwebview] Apply formattings

3ec2eb1

[webview_flutter_android] Remove getCookies_returnsEmptyStringIfNull

5c25776

https://github.com/flutter/packages/pull/10833/changes/BASE..b38e3e7f019db61218e4233906a4060ba9ca738b#r2838733074

github-actions Bot added platform-android platform-ios platform-macos p: webview_flutter labels Mar 30, 2026

gemini-code-assist Bot reviewed Mar 30, 2026

View reviewed changes

khaled-0 added 2 commits March 30, 2026 13:22

[webview_flutter_android][webview_flutter_wkwebview] Bump version, ad…

09a5802

…d changelog

[webview_flutter_wkwebview] Follow RFC 6265 guideline for `getCookies…

2f01b98

…` domain matching

khaled-0 force-pushed the implementations branch from 8257284 to 2f01b98 Compare March 30, 2026 07:59

stuartmorgan-g requested review from LongCatIsLooong, bparrishMines and mboetger March 31, 2026 18:26

stuartmorgan-g added triage-ios Should be looked at in iOS triage triage-android Should be looked at in Android triage federated: partial_changes PR that contains changes for only a single package of a federated plugin change labels Mar 31, 2026

LongCatIsLooong approved these changes Apr 10, 2026

View reviewed changes

[webview_flutter_wkwebview][webview_flutter_android] Fail early in HT…

ab380f1

…TPCookieStoreProxyAPITests. Remove unnecessary late in _onListCookies

mboetger approved these changes Apr 13, 2026

View reviewed changes

camsim99 added the CICD Run CI/CD label Apr 14, 2026

Merge branch 'main' into implementations

a7bc03c

github-actions Bot removed the CICD Run CI/CD label Apr 14, 2026

khaled-0 mentioned this pull request Apr 15, 2026

[webview_flutter] Implement getCookies #10833

Open

11 tasks

gmackall removed the triage-android Should be looked at in Android triage label Apr 21, 2026

fix version bump

8ac1939

bparrishMines added the CICD Run CI/CD label Apr 27, 2026

bparrishMines added 2 commits April 28, 2026 11:05

fix generated dart

979af46

Merge branch 'main' of github.com:flutter/packages into implementations

14facae

github-actions Bot removed the CICD Run CI/CD label Apr 28, 2026

bparrishMines added the CICD Run CI/CD label Apr 28, 2026

fix pubspec android

f1accca

github-actions Bot removed the CICD Run CI/CD label Apr 28, 2026

bparrishMines added the CICD Run CI/CD label Apr 28, 2026

fix remove test

f258911

github-actions Bot removed the CICD Run CI/CD label Apr 28, 2026

bparrishMines added the CICD Run CI/CD label Apr 28, 2026

bparrishMines approved these changes Apr 29, 2026

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026

auto-submit Bot merged commit ff0189e into flutter:main Apr 29, 2026
83 checks passed

Conversation

khaled-0 commented Mar 30, 2026

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

khaled-0 Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LongCatIsLooong Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

khaled-0 Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

khaled-0 Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

mboetger left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Apr 14, 2026

Uh oh!

camsim99 commented Apr 14, 2026

Uh oh!

khaled-0 commented Apr 14, 2026

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants