[url_launcher_web] Re-enable flaky test (not flaky anymore)#11478
Merged
auto-submit[bot] merged 3 commits intomainfrom Apr 30, 2026
Merged
[url_launcher_web] Re-enable flaky test (not flaky anymore)#11478auto-submit[bot] merged 3 commits intomainfrom
auto-submit[bot] merged 3 commits intomainfrom
Conversation
github-actions
Bot
added
p: google_sign_in
CICD
Contributor
Author
|
@stuartmorgan-g I found another test that was previously disabled. Please take another look. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the link_widget_test.dart file by reformatting a testWidgets call and removing the skip: true parameter, thereby enabling the test that verifies anchor attributes in the WebLinkDelegate. There is no feedback to provide.
mdebbar
added
CICD
pull Bot
pushed a commit
to Klomgor/flutter
that referenced
this pull request
May 1, 2026
…r#185897) flutter/packages@cde5b36...daf30f8 2026-04-30 mdebbar@google.com [url_launcher_web] Re-enable flaky test (not flaky anymore) (flutter/packages#11478) 2026-04-30 stuartmorgan@google.com [in_app_purchase] Switch to Kotlin Pigeon (flutter/packages#11608) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] Fix mouse event loop when calling setState in TableSpan.onEnter (flutter/packages#11606) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] trailing pinned row/col for TableView (flutter/packages#11519) 2026-04-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate` (flutter/packages#11567) 2026-04-29 stuartmorgan@google.com [google_maps_flutter] Replace use of zIndex in examples and tests (flutter/packages#11572) 2026-04-29 stuartmorgan@google.com [tool] Remove --against-pub flag (flutter/packages#11550) 2026-04-29 47866232+chunhtai@users.noreply.github.com [ci] Update branch management for batch release (flutter/packages#11575) 2026-04-29 spkhalad@gmail.com [webview_flutter] Platform implementations for getCookies flutter#11037 (flutter/packages#11386) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't seen these tests fail since the underlying issue was fixed and rolled in.
Closes flutter/flutter#182844