[tool] Extract most conformance checks to separate validator classes by stuartmorgan-g · Pull Request #11610 · flutter/packages

stuartmorgan-g · 2026-04-29T19:40:36Z

Extracts the logic for many of the lightweight, repo-practice commands into separate validator classes, leaving just a minimal amount of logic in the command, in preparation for combining all of these into a single command. Doing so will make running conformance checks locally much easier since there will be fewer commands to run, and will make documenting both the tool itself, and the commands we want run against PRs (e.g., for agent instructions), easier as well.

This is a mostly no-op code move, so that tests can change as little as possible in this PR. Then the next PR will then combine the commands, which will require a lot of test changes, but almost all of the non-test code will be able to stay unchanged because it's in the separate validator classes, which the combined command can call into as they are.

All the new files were created by moving code from the corresponding command file, with very minimal changes (e.g., sometimes context that was a non-private getter from the base command class is a private field in the validator class, so underscores were added.) This is reflected in the fact that there are almost no test changes.

…result

gemini-code-assist

Code Review

This pull request refactors the repository's validation logic by extracting validation rules into dedicated validator classes for Dependabot, Gradle, pubspec, README, repository information, and version/changelog checks. It also introduces a utility function for generating POSIX-compliant relative paths. The changes improve code modularity and maintainability by separating validation logic from command execution.

gemini-code-assist · 2026-04-29T19:44:41Z

+    return succeeded;
+  }
+
+  /// Validates that [gradleLines] reads and uses a artifiact hub repository


There is a typo in the documentation comment: "a artifiact" should be "an artifact".

Suggested change

/// Validates that [gradleLines] reads and uses a artifiact hub repository

/// Validates that [gradleLines] reads and uses an artifact hub repository

References

Code should follow the relevant style guides for each language, which includes correct spelling and grammar in documentation. ^(link)

gemini-code-assist · 2026-04-29T19:44:41Z

+}
+  ''';
+
+  /// Validates that [gradleLines] reads and uses a artifiact hub repository


There is a typo in the documentation comment: "a artifiact" should be "an artifact".

Suggested change

/// Validates that [gradleLines] reads and uses a artifiact hub repository

/// Validates that [gradleLines] reads and uses an artifact hub repository

References

Code should follow the relevant style guides for each language, which includes correct spelling and grammar in documentation. ^(link)

gemini-code-assist · 2026-04-29T19:44:42Z

+          '''
+$buildGradleName "namespace" must match the "package" attribute in AndroidManifest.xml, if one is present.
+  $buildGradleName namespace: "$namespace"
+  AndroidMastifest.xml package: "${packageMatch.group(1)}"


There is a typo in the error message: "AndroidMastifest.xml" should be "AndroidManifest.xml".

Suggested change

AndroidMastifest.xml package: "${packageMatch.group(1)}"

AndroidManifest.xml package: "${packageMatch.group(1)}"

References

Code should follow the relevant style guides for each language, which includes correct spelling in user-facing messages. ^(link)

gemini-code-assist · 2026-04-29T19:44:42Z

+      if (implements == null) {
+        return 'Missing "implements: $expectedImplements" in "plugin" section.';
+      } else if (implements != expectedImplements) {
+        return 'Expecetd "implements: $expectedImplements"; '


There is a typo in the error message: "Expecetd" should be "Expected".

Suggested change

return 'Expecetd "implements: $expectedImplements"; '

return 'Expected "implements: $expectedImplements"; '

References

Code should follow the relevant style guides for each language, which includes correct spelling in user-facing messages. ^(link)

gemini-code-assist · 2026-04-29T19:44:42Z

+
+  String _issueTagForPackage(String packageName) {
+    // TODO(stuartmorgan): Move this to a config file. See
+    // https://github.com/flutter/flutter/issues/185364


The issue link in the TODO appears to have a typo. Issue 185364 does not exist in the flutter/flutter repository, whereas issue 155364 specifically discusses moving issue labels to a config file, which matches the context of this TODO.

Suggested change

// https://github.com/flutter/flutter/issues/185364

// https://github.com/flutter/flutter/issues/155364

stuartmorgan-g · 2026-04-29T19:41:59Z

  }

-  test('skips with no supported ecosystems', () async {
+  test('passes with no supported ecosystems', () async {


Skipping won't make sense in the combined command (no package skips all of the checks that will be in the combined command), so I didn't restructure the common validator pattern to allow it just for this command, only to remove it again in the next PR, and instead changed this behavior now.

stuartmorgan-g · 2026-04-29T19:42:17Z

All the changes in this file are just because the constants moved.

stuartmorgan-g · 2026-04-29T19:43:43Z

-              p.split(p.relative(f.absolute.path, from: root.path)),
-            ),
+            (File f) =>
+                relativePosixPath(f, from: root, platformContext: p.posix),


Since I was extracting a helper for use in the validators (to replace the one in the looping command), I changed this to use the new helper that has the same logic.

stuartmorgan-g · 2026-04-29T19:45:08Z

-              'Allowing breaking change to plugin_platform_interface due '
-              'to --ignore-platform-interface-breaks',
+              'Ignoring breaking change to plugin_platform_interface due '
+              'to command configuration',


I didn't want to pass in the flag name to the validator just to keep this message the same. I don't think having the message be less descriptive is going to matter for a flag that's only run in CI, and in a message that's just for auditing if something weird ever happens. We'll still be able to trace the message back to this line.

bparrishMines

LGTM

…factor

auto-submit · 2026-05-04T13:11:19Z

autosubmit label was removed for flutter/packages/11610, because - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r#186002) flutter/packages@daf30f8...a2ad7e3 2026-05-04 stuartmorgan@google.com [tool] Extract most conformance checks to separate validator classes (flutter/packages#11610) 2026-05-01 fluttergithubbot@gmail.com Sync release-go_router-17.2.3 to main (flutter/packages#11633) 2026-05-01 engine-flutter-autoroll@skia.org Roll Flutter from 81bc3d6 to 707dbc0 (85 revisions) (flutter/packages#11630) 2026-05-01 stuartmorgan@google.com [google_maps_flutter] Fix styles on web (flutter/packages#11629) 2026-05-01 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 02085fe to 00b0c91 (3 revisions) (flutter/packages#11627) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan-g added 6 commits April 29, 2026 15:22

Extract most of the readme check into a separate validator class

9ef5601

Extract most of pubuspec check into a validator

50be44e

Extract most of the repo info check into a validator

d8b475e

Extract most of the version/changelog check into a validator

1286e72

Extract most of dependabot check into a validator, removing the skip …

b6ee45f

…result

Extract most of the gradle check into a validator

99af76e

stuartmorgan-g requested a review from bparrishMines April 29, 2026 19:40

flutter-dashboard Bot added the CICD Run CI/CD label Apr 29, 2026

gemini-code-assist Bot reviewed Apr 29, 2026

View reviewed changes

stuartmorgan-g commented Apr 29, 2026

View reviewed changes

bparrishMines approved these changes May 1, 2026

View reviewed changes

stuartmorgan-g added 2 commits May 4, 2026 08:07

Merge branch 'main' into tool-conformance-commands-pre-combination-re…

8be6599

…factor

Autoformat

3a34dee

github-actions Bot removed the CICD Run CI/CD label May 4, 2026

stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels May 4, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2026

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2026

auto-submit Bot merged commit a2ad7e3 into flutter:main May 4, 2026
83 checks passed

This was referenced May 4, 2026

Roll Packages from daf30f846815 to a2ad7e3af184 (5 revisions) flutter/flutter#185983

Closed

Roll Packages from daf30f846815 to a2ad7e3af184 (5 revisions) flutter/flutter#186002

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tool] Extract most conformance checks to separate validator classes#11610

[tool] Extract most conformance checks to separate validator classes#11610
auto-submit[bot] merged 8 commits intoflutter:mainfrom
stuartmorgan-g:tool-conformance-commands-pre-combination-refactor

stuartmorgan-g commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Uh oh!

stuartmorgan-g Apr 29, 2026

Uh oh!

stuartmorgan-g Apr 29, 2026

Uh oh!

stuartmorgan-g Apr 29, 2026

Uh oh!

stuartmorgan-g Apr 29, 2026

Uh oh!

bparrishMines left a comment

Uh oh!

auto-submit Bot commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// Validates that [gradleLines] reads and uses a artifiact hub repository
	/// Validates that [gradleLines] reads and uses an artifact hub repository

	AndroidMastifest.xml package: "${packageMatch.group(1)}"
	AndroidManifest.xml package: "${packageMatch.group(1)}"

	return 'Expecetd "implements: $expectedImplements"; '
	return 'Expected "implements: $expectedImplements"; '

	// https://github.com/flutter/flutter/issues/185364
	// https://github.com/flutter/flutter/issues/155364

Conversation

stuartmorgan-g commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants