[url_launcher] Remove obsolete LICENSE entry#11631
[url_launcher] Remove obsolete LICENSE entry#11631stuartmorgan-g wants to merge 3 commits intoflutter:mainfrom
Conversation
The third-party code in `google_maps_flutter_web` was removed in flutter#4330, but we never removed: - The top-level LICENSE file entry for that code - The repo tooling allowance for that copyright/license This removes those remaining pieces. Part of flutter/flutter#129575
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
There was a problem hiding this comment.
Code Review
This pull request increments the version of google_maps_flutter_web to 0.6.2+1 and updates its changelog. However, the license modifications and tool regex removals were applied to url_launcher_web instead of the intended package. Feedback indicates that the wrong license file and regex were likely modified, as the changes do not align with the package being versioned.
|
Trying again, this time without forgetting which of the web packages with third-party code I was actually changing... |
The third-party code in
url_launcher_webwas removed in #4330, but we never removed:This removes those remaining pieces.
Part of flutter/flutter#129575
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2