Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular embedding sample #2147

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update Angular embedding sample #2147

merged 1 commit into from
Jan 24, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 24, 2024

  • Replace package:js usage with dart:js_interop
  • Remove and ignore package-lock.json since it keeps causing security warnings: https://github.com/flutter/samples/security/dependabot. It's not necessary for this sample and the constraints already present in the package.json.
  • Update to Angular 17.1

@parlough parlough requested a review from johnpryan January 24, 2024 20:18
@parlough parlough merged commit 81512c6 into main Jan 24, 2024
10 of 14 checks passed
@parlough parlough deleted the misc/ng-embedding-update branch January 24, 2024 21:53
@kevmoo
Copy link
Contributor

kevmoo commented Jan 26, 2024

Bless you, @parlough! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants