Reverts "Update Zulip tests and re-enable (#441)" #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 8cf7a67.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jan 22, 2025
auto-submit
bot
deleted the
revert_8cf7a67e450069962ec14335cc47e4d980e23f30
branch
victoreronmosele
pushed a commit
to victoreronmosele/tests
that referenced
this pull request
Feb 5, 2025
Reverts: flutter#441 Initiated by: matanlurey Reason for reverting: sudo apt-get install does not work on LUCI Original PR Author: gnprice Reviewed By: {Piinks} This change reverts the following previous change: This has the update to unblock autocomplete changes: zulip/zulip-flutter#1190 flutter/flutter#143249 and with that, tests pass again on Flutter main. Also install libsqlite3-dev on Linux, a package which is no longer included in GitHub's new version of the "ubuntu-latest" images. The lack of it causes nondeterministic failures when the runner happens to use the new image: flutter#441 (comment) The actual shared library file libsqlite3.so.0.8.6 -- in the package libsqlite3-0 -- is still installed by default anyway. This package adds the symlink at "libsqlite3.so", which is the filename some libraries apparently look for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #441
Initiated by: matanlurey
Reason for reverting: sudo apt-get install does not work on LUCI
Original PR Author: gnprice
Reviewed By: {Piinks}
This change reverts the following previous change:
This has the update to unblock autocomplete changes:
zulip/zulip-flutter#1190
flutter/flutter#143249
and with that, tests pass again on Flutter main.
Also install libsqlite3-dev on Linux, a package which is no longer
included in GitHub's new version of the "ubuntu-latest" images. The
lack of it causes nondeterministic failures when the runner happens
to use the new image:
#441 (comment)
The actual shared library file libsqlite3.so.0.8.6 -- in the package
libsqlite3-0 -- is still installed by default anyway. This package
adds the symlink at "libsqlite3.so", which is the filename some
libraries apparently look for.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.