Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button border-radius added #11664

Merged
merged 1 commit into from
Feb 3, 2025
Merged

button border-radius added #11664

merged 1 commit into from
Feb 3, 2025

Conversation

zalabhavy
Copy link
Contributor

In the Navbar, the 'Get Started' button has sharp angles. Instead, we should make it rounded by adding a border radius.

Fixed #11622

Now Looks better with round shape 😊

image

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@zalabhavy zalabhavy requested review from sfshaza2, antfitch, parlough and a team as code owners February 2, 2025 18:35
Copy link

google-cla bot commented Feb 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@zalabhavy
Copy link
Contributor Author

@parlough @Sfshaza @antfitch Please check it and let me know if any changes are required.

A special thanks to @parlough for giving me the opportunity to try and solve my doubts and errors while running it on my local machine. Finally, everything is set, and I'm eager to contribute!

@parlough
Copy link
Member

parlough commented Feb 2, 2025

Thanks so much for sticking with this and making this improvement @zalabhavy!

However, as the [bot comment above says(https://github.com//pull/11664/checks?check_run_id=36552750354), you'll need to sign the Google CLA with your commit email before we can review and land the PR. If you have any issues doing so, let me know. Thanks again :)

@zalabhavy
Copy link
Contributor Author

zalabhavy commented Feb 3, 2025

@parlough I have done rescan after CLA sign.

image image

@zalabhavy
Copy link
Contributor Author

@parlough Now CLA pass after some commits 😁

@parlough
Copy link
Member

parlough commented Feb 3, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 48fbdb4):

https://flutter-docs-prod--pr11664-fixbtn-1hqj0iow.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for sticking with this @zalabhavy! Looks much better and also more consistent with the root flutter.dev :D

@parlough parlough merged commit 47c1ec6 into flutter:main Feb 3, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give Get started button some radius in Navbar
3 participants