-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
button border-radius added #11664
button border-radius added #11664
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks so much for sticking with this and making this improvement @zalabhavy! However, as the [bot comment above says(https://github.com//pull/11664/checks?check_run_id=36552750354), you'll need to sign the Google CLA with your commit email before we can review and land the PR. If you have any issues doing so, let me know. Thanks again :) |
@parlough I have done rescan after CLA sign. ![]() ![]() |
@parlough Now CLA pass after some commits 😁 |
/gcbrun |
Visit the preview URL for this PR (updated for commit 48fbdb4): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for sticking with this @zalabhavy! Looks much better and also more consistent with the root flutter.dev :D
In the Navbar, the 'Get Started' button has sharp angles. Instead, we should make it rounded by adding a border radius.
Fixed #11622
Now Looks better with round shape 😊
Presubmit checklist