Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant use material3 #11693

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

2shrestha22
Copy link
Contributor

@2shrestha22 2shrestha22 commented Feb 8, 2025

Description of what this PR is changing or adding, and why:
This PR removes redundant useMaterial3 since it is true by default.

Issues fixed by this PR (if any):
flutter/flutter#162818

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely true, but waiting for build to finish to make sure that the code excerpts are up to date.

@sfshaza2
Copy link
Contributor

As I suspected. @2shrestha22, can you refresh the code excerpts on your build and re-submit the changes. It's described in the failed results of the test pass:

Error: Some code excerpts needed to be updated!
  Run `./dash_site refresh-excerpts` to update.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and ran the command to update the copies of the excerpts for you.

Thanks so much for updating these snippets!

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit bc64ff6):

https://flutter-docs-prod--pr11693-remove-redundant-usemateria-92n256je.web.app

@parlough parlough merged commit 5d44cab into flutter:main Feb 10, 2025
9 checks passed
@2shrestha22 2shrestha22 deleted the remove-redundant-useMaterial3 branch February 11, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants