-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Include a java too new path in android-java-gradle-migration #11708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit a69b763): https://flutter-docs-prod--pr11708-r-java-version-confustion-t-zsnn5gkp.web.app |
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content LGTM, I'll let our tech writers review for style, format, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicky comments.
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Follow up on after some pairing with @anderdobo and @kenzieschmoll covering android agp updates.
Presubmit checklist