Skip to content

Include a java too new path in android-java-gradle-migration #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

reidbaker
Copy link
Contributor

Follow up on after some pairing with @anderdobo and @kenzieschmoll covering android agp updates.

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 11, 2025

Visit the preview URL for this PR (updated for commit a69b763):

https://flutter-docs-prod--pr11708-r-java-version-confustion-t-zsnn5gkp.web.app

@reidbaker
Copy link
Contributor Author

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content LGTM, I'll let our tech writers review for style, format, etc.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicky comments.

reidbaker and others added 5 commits February 12, 2025 10:31
…tion-guide.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…tion-guide.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 2b22a9c into main Feb 12, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the r-java-version-confustion-too-new-2025-02-11 branch February 12, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants