Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cupertino examples to the Floating App Bar recipe. #11821

Merged
merged 5 commits into from
Mar 18, 2025
Merged

Add cupertino examples to the Floating App Bar recipe. #11821

merged 5 commits into from
Mar 18, 2025
+364 −140

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Mar 14, 2025 •
edited
Loading

Description of what this PR is changing or adding, and why:

  • Added code sample for a Cupertino floating navigation bar (thanks @loic-sharma!)
  • Added Cupertino code excerpts.
  • Updated the Material code example to pin the app bar, but in a minimized style (matches Cupertino example and looks nice, imo)
  • Added tabs & moved Material and Cupertino specific content into tabs.
  • In some cases, I reduced text in the intro section to be style agnostic.
  • Moved some content into an Overview so that we can easily get to that content through the right-pane TOC.

Note: It's not easy to tell when content belongs to a tab. We might consider adding some shading back to our tabs. Just a thought for the future.

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough and a team as code owners March 14, 2025 21:50
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 14, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 869aa0e):

https://flutter-docs-prod--pr11821-ios-floating-app-bar-pezzbxio.web.app

@antfitch
Copy link
Contributor Author

@Sfshaza a test is failing. To appease the test, I'll have to add a const keyword in step 2 and then have developers remove it in step 3. What would you like me to do here?

@antfitch antfitch self-assigned this Mar 17, 2025
@sfshaza2
Copy link
Contributor

@Sfshaza a test is failing. To appease the test, I'll have to add a const keyword in step 2 and then have developers remove it in step 3. What would you like me to do here?

Yeah, I don't love it, but I guess it's ok. We do need to appease the build.

@antfitch
Copy link
Contributor Author

antfitch commented Mar 17, 2025 •
edited
Loading

@Sfshaza a test is failing. To appease the test, I'll have to add a const keyword in step 2 and then have developers remove it in step 3. What would you like me to do here?

Yeah, I don't love it, but I guess it's ok. We do need to appease the build.

I managed to make things work! Whew. All tests should run successfully now.

loic-sharma
loic-sharma reviewed Mar 17, 2025
View reviewed changes
examples/cookbook/lists/floating_app_bar/lib/main_cupertino.dart Outdated
// #docregion SliverList
// Next, create a SliverList
SliverList.builder(
// The builder function returns a ListTile with a title that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ListTile should be CupertinoListTile here and on line 32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

loic-sharma
loic-sharma approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

sfshaza2
sfshaza2 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfshaza2 sfshaza2 merged commit 1185529 into flutter:main Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees

@antfitch antfitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antfitch @flutter-website-bot @sfshaza2 @loic-sharma