-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance pubspec guide #11833
base: main
Are you sure you want to change the base?
Enhance pubspec guide #11833
Conversation
Visit the preview URL for this PR (updated for commit 574a86b): https://flutter-docs-prod--pr11833-conditionally-build-assets-4acsj9hk.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antfitch, this is a huge improvement! lgtm
Co-authored-by: Andrew Kolos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how thorough you want this to be, but I found some other obscure settings:
I believe these have both been turned down. I will double check...
And I've added new sections for both of these. ^_^ |
Why do you think it's only for Android? Seems like at least iOS can use it too |
I see references to it not working in flutter/flutter#147968, but @andrewkolos mentioned that it should work. I will go with the team's impression that it does work. |
@reidbaker can you take another look at the |
Description of what this PR is changing or adding, and why:
The existing guide was missing some supported fields and listing some packages as fields. The guide has a very nice robust example, but no robust documentation about the fields and packages in the example. To address this, I added a section called
Fields
and a section calledPackages
that goes over the Flutter-specific field and packages, and more specifically, the various data structures that can exist for each field.@Sfshaza if you think this idea works and you like the general design, @andrewkolos, @vashworth, and @reidbaker can you look closely over the technical details? Am I missing any fields or packages? I have no idea how large the package list is and wasn't sure if we should document this here.
Notes:
/
, and in some fields the/
will produce an error.Preview:
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist