FEAT: change SizeConstraint ignoreSize defualt to true - #1259
Conversation
|
Changing the flag would be a breaking change for users who wrote a valid condition but didn't toggled the flag before. |
|
But it originally felt like there was wrong, the default value theory should be unconditional, which would be more reasonable. However, a condition (0 < width < 100000) was added by default. If I really have an image larger than 100000, wouldn't it fail to be filtered out? I think this is not the expected behavior of the user. But then again, 100000 is really too large, almost non-existent such big images, and if such an image were to be loaded into memory all at once, it would definitely cause outofmemory, |
If we could convert |
The expression "0 < width < 100000" has the same effect as "ignoreSize = true" but adding these two conditions in SQL might degrade performance somewhat.