Refactor getSortOrder in IDBUtils.kt to ensure valid SQL query construction by providing a default ORDER BY clause when no filter option is specified. #1352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Xiaomi Mi Mix 2
Fix Android album query SQL ( DBUtils#getAssetPathList )
BUCKET_ID IS NOT NULLbucket_id IS NOT NULL … GROUP BY. On stricter OEM MediaStore implementations this caused SQLiteException: no such column: NULLbucket_id when loading albums.BUCKET_ID IS NOT NULLplus the filter clause, with proper spacing and grouping, eliminating the malformed column token.Ensure valid sort clause for paging ( IDBUtils#getSortOrder )
ORDER BY LIMIT … OFFSET …, which is invalid SQL and producednear "LIMIT": syntax erroron some devices when paging assets.DATE_ADDED DESC, DATE_MODIFIED DESC) beforeLIMIT/OFFSET, so paging queries are syntactically correct across devices.