Skip to content

支持业务 App 页面浏览的埋点述求 #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

支持业务 App 页面浏览的埋点述求 #692

merged 1 commit into from
May 23, 2025

Conversation

gavinliu
Copy link
Contributor

在 AssetPickerPageRoute 构造函数中添加 super.settings 配置，以便于通过 NavigatorObserver 采集页面浏览时，能够正确拿到 RouteSettings

@gavinliu
refactor(widget): 在AssetPickerPageRoute构造函数中添加super.settings
e0d8256 
为了增强路由配置的灵活性，允许通过构造函数传递 settings ，以便在页面统计时，获取到 settings 相关信息
@AlexV525
Copy link
Member

感谢贡献，其他本地重载的成员变量看下是不是顺便改成使用 super

@gavinliu
Copy link
Contributor Author

gavinliu commented May 23, 2025 •
edited
Loading

感谢贡献，其他本地重载的成员变量看下是不是顺便改成使用 super

我看了下其他成员变量，主要是控制页面焦点、动画、全屏这些显示效果。考虑到这个页面本身就是全屏的，感觉没必要继续对外暴露。

@AlexV525 AlexV525 merged commit 7f06b77 into fluttercandies:main May 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 Awaiting requested review from AlexV525 AlexV525 is a code owner

@LeGoffMael LeGoffMael Awaiting requested review from LeGoffMael LeGoffMael is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinliu @AlexV525