Skip to content

fix: remove usage hashValues in favor Object.hash #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

mikklfr
Copy link
Contributor

@mikklfr mikklfr commented Jan 10, 2025

Following flutter/flutter#85431, this commit allows the library to work under latest Flutter version 3.27.1

@mikklfr
Copy link
Contributor Author

mikklfr commented Jan 10, 2025

@renefloor @koozz
I created a PR against code that works locally, seems similar to other ones on the repo, I signed the commit if you want to merge it.
Thanks

Signed-off-by: Michaël Ohayon <[email protected]>
@koozz koozz requested a review from renefloor January 13, 2025 07:49
@sandruschka
Copy link

We definitely need this fix please :)

@Vlad-Adrian
Copy link

@renefloor, your review would be much appreciated 🚀

renefloor
renefloor previously approved these changes Jan 23, 2025
Signed-off-by: Michaël Ohayon <[email protected]>
@mikklfr
Copy link
Contributor Author

mikklfr commented Jan 23, 2025

I updated Flutter version used by CI, if you want try another run of the Github Action it should be better now

Copy link
Collaborator

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renefloor
Copy link
Collaborator

You can ignore the warnings from the Dart / build workflow, we haven't made it required yet and I'll fix them later

@koozz koozz merged commit 2848c56 into fluttercommunity:master Jan 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants