-
Notifications
You must be signed in to change notification settings - Fork 71
fix: add support for non-root base-href #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
holzgeist
wants to merge
23
commits into
fluttercommunity:main
Choose a base branch
from
holzgeist:fix-support-non-root-base-href
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8892812
fix: add support for non-root base-href
holzgeist 31526ae
Moved no_sleep.js to lib/assets.
diegotori 606ade6
Added web alias to all package:web calls in import_js_library.dart.
diegotori b4114a9
Added more simplified library URL method in import_js_library.dart.
diegotori e948054
WakelockPlusWebPlugin now lazily loads no_sleep.js on demand as oppos…
diegotori 9e1fd5b
Got the WakelockPlusWebPlugin tests passing.
diegotori 39f6598
Fixed example app web-related depreactions.
diegotori f2542bd
Added straggler from previous commit.
diegotori b8d0b58
Added correct script tag error handling by checking if the target is …
diegotori bd3e7a7
Upgraded flutter_lints to latest version.
diegotori 4900aaf
Revamped the no_sleep.js script to use a Promise-based Completer so t…
diegotori ac4e069
Fixed a dart lint issue due to HTML in the documentation of _importJS…
diegotori a7ddb22
Added minor comments to no_sleep.js.
diegotori 897dca4
Merge branch 'main' into fix-support-non-root-base-href
diegotori f5d5bc4
Fixed a pubspec straggler from the previous commit.
diegotori 8f38c22
Update wakelock_plus/lib/assets/no_sleep.js due to typo
diegotori bb3d4ca
chore: apply suggestions
holzgeist be5d5f5
Merge branch 'main' into fix-support-non-root-base-href
diegotori bb5d60d
Moved no_sleep.js copyright notice to the top of the file.
diegotori 12cd725
fix: don't perform any work after completing future
holzgeist 8f1ed7a
Merge branch 'main' into fix-support-non-root-base-href
diegotori 3886996
Merge branch 'main' into fix-support-non-root-base-href
diegotori 27f6d07
Merge branch 'main' into fix-support-non-root-base-href
diegotori File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.