readme: add installation instructions#113
Conversation
garlick
left a comment
There was a problem hiding this comment.
Thanks! I put a comment inline. I think two main take-aways are
- you can set PKG_CONFIG_PATH on the command line rather than exporting so it doesn't get set in someones interactive shell environment and affect other things they build
- PKG_CONFIG_PATH is used at configure time rather than make time IIUC
| export PKG_CONFIG_PATH=${flux_install}/lib/pkgconfig:$(pkg-config --variable pc_path pkg-config) | ||
| ``` | ||
|
|
||
| Run that before `make`. |
There was a problem hiding this comment.
Usually the PKG_CONFIG_PATH needs to be set before ./configure?
I usually use a script similar to this
#!/bin/bash
PMIX_PREFIX=/opt/openpmix-4.2.2
OMPI_PREFIX=/opt/openmpi-5.0.0rc9
FLUX_CORE_PREFIX=/opt/flux-core-v0.46.1-54
PKG_CONFIG_PATH=$(pkg-config --variable pc_path pkg-config)
#PKG_CONFIG_PATH=${OMPI_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}
PKG_CONFIG_PATH=${PMIX_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}
PKG_CONFIG_PATH=${FLUX_CORE_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}
PKG_CONFIG_PATH=${PKG_CONFIG_PATH} \
./configure
There was a problem hiding this comment.
Thanks for the reminder @garlick! I pushed up your script, with a small tweak to make it do the whole build + install, and install to the flux-core prefix. Let me know if that works.
|
@wihobbs did you want to fix this one and get it into the next release? |
11cff0d to
214f921
Compare
garlick
left a comment
There was a problem hiding this comment.
Thanks! Some comments inline for you to consider.
| To configure flux-pmix with a side-installed version of pmix and/or flux-core, | ||
| you will need to make sure that side install's pkg-config files are exported. | ||
| For an example of how to do that, see the example script below: |
There was a problem hiding this comment.
Maybe instead
To install flux-pmix with a side-installed flux-core so that the plugins provided by flux-pmix can be found on flux's default search paths, build and install to the same prefix. Here is an example script that uses pkg-config:
There was a problem hiding this comment.
Sounds good, changed and pushed.
Problem: there are no instructions in the readme for how to install flux-pmix. Add some.
|
@garlick okay to set MWP? |
|
Thanks - feel free to set MWP |
|
Hmm, it looks like I don't have write access here to add labels. |
|
Oh weird. I'll set it. |
Problem: there are no instructions in the readme for how to install flux-pmix.
Add some.
Fixes #112.