[KC] Add DirectSourceFetch feature gate to bypass cache for source objects#1586
Open
dipti-pai wants to merge 1 commit intofluxcd:mainfrom
Open
[KC] Add DirectSourceFetch feature gate to bypass cache for source objects#1586dipti-pai wants to merge 1 commit intofluxcd:mainfrom
dipti-pai wants to merge 1 commit intofluxcd:mainfrom
Conversation
dipti-pai
changed the title
This feature gate enables fetching source objects (GitRepository, OCIRepository, Bucket) directly from the API server using APIReader, bypassing the controller's cache. This can be useful when immediate consistency is required for source object reads. When enabled via --feature-gates=DirectSourceFetch=true: - Source objects are fetched using r.APIReader instead of r.Client - A log message is emitted at startup indicating the feature is active Changes: - Add DirectSourceFetch field to KustomizationReconciler struct - Update getSource() to use APIReader when feature is enabled - Register feature gate with default value false (opt-in) - Add unit tests for GitRepository, OCIRepository, and Bucket sources - Update pkg/runtime dependency to v0.100.1 - Downgrade pkg/ssa to v0.67.1 Signed-off-by: Dipti Pai <diptipai89@outlook.com> Downgrade ssa Signed-off-by: Dipti Pai <diptipai89@outlook.com>
dipti-pai
force-pushed
the
direct-source-fetch
branch
from
a695718 to
ebfc86f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature gate enables fetching source objects (GitRepository, OCIRepository, Bucket) directly from the API server using APIReader, bypassing the controller's cache. This can be useful when immediate consistency is required for source object reads.
When enabled via --feature-gates=DirectSourceFetch=true:
Changes:
Fixes: #1583