Vendor the dynamic RESTMapper from controller-runtime v0.19 #873
+449
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
the
area/runtime
stefanprodan
force-pushed
the
lazy-restmapper
branch
2 times, most recently
from
4ebbb5e to
c6e68fd
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
lazy-restmapper
branch
from
c6e68fd to
7c5e477
Compare
stefanprodan
changed the title
Signed-off-by: Stefan Prodan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the RESTMapper from controller-runtime v0.19 before The Kubernetes Aggregated Discovery was enabled
in controller-runtime v0.20 which broke the preferred version discovery of custom resources.
This PR refactors the client impersonation by always returning a kstatus poller using the lazy RESTMapper.
This PR allows us to use the latest controller-runtime while not breaking the preferred version discovery needed by kstatus.
xref: fluxcd/kustomize-controller#1373