refactor(framework) Convert Driver.pull_messages to no-arg#5067
Closed
chongshenng wants to merge 22 commits intomainfrom
Closed
refactor(framework) Convert Driver.pull_messages to no-arg#5067chongshenng wants to merge 22 commits intomainfrom
Driver.pull_messages to no-arg#5067chongshenng wants to merge 22 commits intomainfrom
Conversation
panh99
reviewed
Mar 12, 2025
panh99
reviewed
Mar 12, 2025
panh99
reviewed
Mar 13, 2025
Comment on lines
+181
to
+184
| def iter_msg() -> Iterator[Message]: | ||
| return iter(message_res_list) | ||
|
|
||
| return iter_msg() |
Member
There was a problem hiding this comment.
Both Iterator and list are acceptable types of Iterable. Since we already have a list of messages, we don't need to convert it to an iterator here.
@jafermarq Should we also update the in memory driver so it really returns an iterator and doesn't pull all messages at once? Wdyt?
Suggested change
| def iter_msg() -> Iterator[Message]: | |
| return iter(message_res_list) | |
| return iter_msg() | |
| return message_res_list |
Member
Author
There was a problem hiding this comment.
Should we also update the in memory driver so it really returns an iterator and doesn't pull all messages at once? Wdyt?
Indeed, that was the original idea - to keep the return behaviour the same for both in-memory driver and the grpc_driver.
Member
Author
|
Closing as this is stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the return of an iterator for the
Driver.pull_messages().