feat(framework) Add flwr-app-scheduler command#5627
Draft
Conversation
github-actions
bot
added
the
Maintainer
jafermarq
reviewed
Jul 24, 2025
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
reviewed
Jul 24, 2025
| parser.add_argument( | ||
| "--plugin-type", | ||
| type=str, | ||
| choices=SchedulerPluginType.all(), |
Comment on lines
+60
to
+77
| parser.add_argument( | ||
| "--insecure", | ||
| action="store_true", | ||
| help="Connect to the AppIO API without TLS. " | ||
| "Data transmitted between the client and server is not encrypted. " | ||
| "Use this flag only if you understand the risks.", | ||
| ) | ||
| parser.add_argument( | ||
| "--flwr-dir", | ||
| default=None, | ||
| help="""The path containing installed Flower Apps. | ||
| By default, this value is equal to: | ||
|
|
||
| - `$FLWR_HOME/` if `$FLWR_HOME` is defined | ||
| - `$XDG_DATA_HOME/.flwr/` if `$XDG_DATA_HOME` is defined | ||
| - `$HOME/.flwr/` in all other cases | ||
| """, | ||
| ) |
Member
There was a problem hiding this comment.
Should we inject these aregs via add_args_flwr_app_common as we do in the flwr-*** commands? For example in flwr-clientapp: https://github.com/adap/flower/blob/ce17e4e2573bb53a94a6a879e871f38a4394ffb2/framework/py/flwr/supernode/cli/flwr_clientapp.py#L87
|
|
||
| # Log the first message after parsing arguments in case of `--help` | ||
| log(INFO, "Starting Flower App Scheduler") | ||
|
|
Member
There was a problem hiding this comment.
Should we add logs similar to those in the flwr-*** commands mentioning about TLS and the address used? For example this is how it's done with flwr-clientapp atm:
https://github.com/adap/flower/blob/ce17e4e2573bb53a94a6a879e871f38a4394ffb2/framework/py/flwr/supernode/cli/flwr_clientapp.py#L32-L45
jafermarq
reviewed
Jul 24, 2025
jafermarq
reviewed
Jul 24, 2025
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.