Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the CI bootstrap action by switching from invoking python -m poetry to using a pipx-isolated poetry installation, ensuring poetry runs in its own isolated environment rather than the project's Python environment. It also bumps pip from version 23.3.1 to 25.3 across CI workflows and replaces bare pip install calls with the more explicit python -m pip install form for consistency.
Changes:
- The bootstrap action installs
poetryviapipx(instead ofpip) and adds$HOME/.local/binto$GITHUB_PATH, enabling barepoetrycommands in all subsequent workflow steps. - All
python -m poetry <command>occurrences across CI workflows and dev scripts are replaced with barepoetry <command>. pipis bumped from23.3.1to25.3in multiple workflow files, and barepip installcalls are standardized topython -m pip install.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/actions/bootstrap/action.yml |
Core change: pip/setuptools installs moved outside the condition block; poetry now installed via pipx into $HOME/.local/bin |
dev/bootstrap.sh |
Switches from python -m poetry install to bare poetry install |
.github/workflows/framework-e2e.yml |
Updates python -m poetry → poetry, bumps pip to 25.3, converts bare pip install to python -m pip install |
.github/workflows/framework-test.yml |
Updates python -m poetry → poetry |
.github/workflows/framework-release.yml |
Updates python -m poetry → poetry |
.github/workflows/framework-docs.yml |
Updates python -m poetry → poetry |
.github/workflows/framework-docs-update-translations.yml |
Updates python -m poetry → poetry, pip install → python -m pip install |
.github/workflows/framework-devtools.yml |
Updates python -m poetry → poetry |
.github/workflows/intelligence-docs.yml |
Updates python -m poetry → poetry |
.github/workflows/build-deploy-non-framework-docs.yml |
Replaces poetry add ../datasets + poetry install with poetry install + python -m pip install ../datasets |
.github/workflows/datasets-test.yml |
Updates python -m poetry → poetry |
.github/workflows/deprecated-baselines.yml |
Updates python -m poetry → poetry |
framework/dev/build.sh |
Updates python -m poetry → poetry |
framework/dev/publish-nightly.sh |
Updates python -m poetry → poetry |
framework/docs/source/contributor-tutorial-get-started-as-a-contributor.rst |
Updates doc example from python -m poetry install to poetry install |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ss' into improve-ci-robustness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
pipandsetuptools, independent ofpoetry-skippoetryusingpipxto isolate it from Python environment that framework/datasets/... are installed in