Skip to content

ci(*:skip): Improve CI bootstrap action#6646

Closed
danieljanes wants to merge 9 commits intomainfrom
improve-ci-robustness
Closed

ci(*:skip): Improve CI bootstrap action#6646
danieljanes wants to merge 9 commits intomainfrom
improve-ci-robustness

Conversation

@danieljanes
Copy link
Collaborator

@danieljanes danieljanes commented Feb 28, 2026

This PR

  • Always pins pip and setuptools, independent of poetry-skip
  • Installs poetry using pipx to isolate it from Python environment that framework/datasets/... are installed in

Copilot AI review requested due to automatic review settings February 28, 2026 11:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the CI bootstrap action by switching from invoking python -m poetry to using a pipx-isolated poetry installation, ensuring poetry runs in its own isolated environment rather than the project's Python environment. It also bumps pip from version 23.3.1 to 25.3 across CI workflows and replaces bare pip install calls with the more explicit python -m pip install form for consistency.

Changes:

  • The bootstrap action installs poetry via pipx (instead of pip) and adds $HOME/.local/bin to $GITHUB_PATH, enabling bare poetry commands in all subsequent workflow steps.
  • All python -m poetry <command> occurrences across CI workflows and dev scripts are replaced with bare poetry <command>.
  • pip is bumped from 23.3.1 to 25.3 in multiple workflow files, and bare pip install calls are standardized to python -m pip install.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/actions/bootstrap/action.yml Core change: pip/setuptools installs moved outside the condition block; poetry now installed via pipx into $HOME/.local/bin
dev/bootstrap.sh Switches from python -m poetry install to bare poetry install
.github/workflows/framework-e2e.yml Updates python -m poetrypoetry, bumps pip to 25.3, converts bare pip install to python -m pip install
.github/workflows/framework-test.yml Updates python -m poetrypoetry
.github/workflows/framework-release.yml Updates python -m poetrypoetry
.github/workflows/framework-docs.yml Updates python -m poetrypoetry
.github/workflows/framework-docs-update-translations.yml Updates python -m poetrypoetry, pip installpython -m pip install
.github/workflows/framework-devtools.yml Updates python -m poetrypoetry
.github/workflows/intelligence-docs.yml Updates python -m poetrypoetry
.github/workflows/build-deploy-non-framework-docs.yml Replaces poetry add ../datasets + poetry install with poetry install + python -m pip install ../datasets
.github/workflows/datasets-test.yml Updates python -m poetrypoetry
.github/workflows/deprecated-baselines.yml Updates python -m poetrypoetry
framework/dev/build.sh Updates python -m poetrypoetry
framework/dev/publish-nightly.sh Updates python -m poetrypoetry
framework/docs/source/contributor-tutorial-get-started-as-a-contributor.rst Updates doc example from python -m poetry install to poetry install

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Feb 28, 2026
@danieljanes danieljanes deleted the improve-ci-robustness branch February 28, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants