Skip to content

ci(framework): Migrate pyproject.toml to use [project]#6651

Merged
danieljanes merged 27 commits intomainfrom
migrate-pyproject
Mar 3, 2026
Merged

ci(framework): Migrate pyproject.toml to use [project]#6651
danieljanes merged 27 commits intomainfrom
migrate-pyproject

Conversation

@danieljanes
Copy link
Collaborator

@danieljanes danieljanes commented Feb 28, 2026

This PR migrates framework/pyproject.toml from [tool.poetry] to [project] and [dependency-groups] (PEP-621 and PEP-735)

Copilot AI review requested due to automatic review settings February 28, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Flower’s Poetry configuration to PEP 621-style [project] metadata and updates CI/docs/nightly tooling to align with the new pyproject structure.

Changes:

  • Move package metadata and runtime dependencies from [tool.poetry] to [project] across framework/devtool (and the e2e strategies project).
  • Update GitHub Actions and contributor docs to use python -m poetry ... and explicit dependency selection (--with dev, --only main, --all-extras).
  • Replace brittle sed-based nightly metadata edits with a small Python helper (framework/dev/pyproject_meta.py).

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
framework/pyproject.toml Converts framework package metadata/deps to [project], adds optional-deps and URLs, reorganizes dev requirements.
framework/e2e/strategies/pyproject.toml Adds [project] metadata/dependencies for the strategies e2e Poetry project.
framework/docs/source/how-to-upgrade-to-flower-1.0.rst Updates Poetry upgrade instructions to use python -m poetry install.
framework/docs/source/contributor-tutorial-get-started-as-a-contributor.rst Updates dev install command to include the dev group.
framework/docs/source/contributor-how-to-write-documentation.rst Updates doc build commands to python -m poetry run ....
framework/docs/source/contributor-how-to-set-up-a-virtual-env.rst Updates virtualenv setup/activation instructions for Poetry.
framework/docs/source/contributor-how-to-install-development-versions.rst Updates prerelease install instructions to python -m poetry install.
framework/dev/pyproject_meta.py New helper to read/update [project] name/version.
framework/dev/publish-nightly.sh Uses pyproject_meta.py instead of sed to set nightly name/version.
dev/pyproject.toml Migrates devtool package metadata/deps to [project].
.github/workflows/framework-test.yml Installs dependencies with --with dev --all-extras.
.github/workflows/framework-release-nightly.yml Reads name/version via pyproject_meta.py instead of poetry version.
.github/workflows/framework-e2e.yml Adjusts Poetry install usage (--with dev --all-extras, --only main).
.github/workflows/framework-docs.yml Ensures docs job installs with the dev group.
.github/workflows/framework-docs-update-translations.yml Uses Poetry dev group instead of extra pip install.
.github/workflows/framework-devtools.yml Installs with the dev group for tool checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Feb 28, 2026
@danieljanes danieljanes changed the base branch from main to improve-ci-pipelines March 1, 2026 13:32
@danieljanes danieljanes marked this pull request as draft March 1, 2026 13:39
Base automatically changed from migrate-pyproject-prepare to main March 2, 2026 09:42
@danieljanes danieljanes marked this pull request as ready for review March 3, 2026 14:52
@danieljanes danieljanes enabled auto-merge (squash) March 3, 2026 14:52
Copy link
Member

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danieljanes danieljanes merged commit 0cd31e4 into main Mar 3, 2026
70 checks passed
@danieljanes danieljanes deleted the migrate-pyproject branch March 3, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants