Skip to content

ci(*:skip): Move all Python scripts under dev into devtool#6655

Merged
danieljanes merged 11 commits intomainfrom
migrate-devtool-py-scripts
Mar 2, 2026
Merged

ci(*:skip): Move all Python scripts under dev into devtool#6655
danieljanes merged 11 commits intomainfrom
migrate-devtool-py-scripts

Conversation

@danieljanes
Copy link
Collaborator

@danieljanes danieljanes commented Mar 1, 2026

Merge after #6654

This PR moves all Python scripts under dev into devtool

Copilot AI review requested due to automatic review settings March 1, 2026 16:18
@danieljanes danieljanes changed the title Migrate devtool py scripts ci(*:skip): Move all Python scripts under dev into devtool Mar 1, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates developer Python utilities into the dev/devtool package and updates docs and CI workflows to invoke these tools via python -m devtool.<module>.

Changes:

  • Update various docs/workflows to use python -m devtool.* (and python -m poetry ...) instead of calling scripts by path.
  • Refactor devtool scripts to use repo-root-relative paths (Path(__file__).resolve().parents[2]) and improve file handling (e.g., UTF-8 reads/writes).
  • Adjust CI workflows (path filters, dependency install steps, wheel install syntax) to align with the new tooling and packaging.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
framework/docs/source/how-to-upgrade-to-flower-1.0.rst Updates Poetry upgrade instructions and command invocation.
framework/docs/source/contributor-how-to-write-documentation.rst Updates local doc build commands to use python -m poetry.
framework/docs/source/contributor-how-to-set-up-a-virtual-env.rst Minor wording update around Poetry virtualenv setup.
framework/docs/source/contributor-how-to-install-development-versions.rst Updates Poetry reinstall instructions and command invocation.
dev/devtool/update_python.py Adjusts internal glob patterns to match new dev/devtool script locations.
dev/devtool/update_html_themes.py Makes script repo-root aware and uses explicit UTF-8 when reading YAML.
dev/devtool/check_pr_title.py Refactors into functions and enables python -m devtool.check_pr_title execution.
dev/devtool/build_example_docs.py Switches to Path for repo-root/index handling and uses UTF-8 for output.
dev/changelog_config.toml Updates comment to reflect new devtool.check_pr_title module usage.
.github/workflows/repo-check-pr-title.yml Switches title check to module invocation with PYTHONPATH=dev.
.github/workflows/framework-test.yml Expands change detection to include dev/devtool/**; renames a step.
.github/workflows/framework-e2e.yml Installs wheel as flwr[simulation] @ URL and tweaks dependency install scope.
.github/workflows/framework-docs-update-translations.yml Removes explicit pip install sphinx==... line during install.
.github/workflows/datasets-test.yml Expands workflow path triggers to include dev/devtool/**.
.github/workflows/build-deploy-non-framework-docs.yml Switches dev scripts to module invocation via devtool.*.
.devcontainer/post-create.sh Changes Poetry install flags to --all-extras.
Comments suppressed due to low confidence (1)

dev/devtool/build_example_docs.py:24

  • There is still a repo script (intelligence/dev/build-docs.sh) invoking the old path python3 dev/build-example-docs.py. Since this PR migrates/renames that script to dev/devtool/build_example_docs.py (and CI now uses python -m devtool.build_example_docs), that remaining caller will break and should be updated to the new module invocation (or to the new file path).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danieljanes danieljanes changed the base branch from main to migrate-pyproject-prepare March 1, 2026 16:24
@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Mar 1, 2026
@danieljanes danieljanes marked this pull request as draft March 1, 2026 17:54
@danieljanes danieljanes changed the base branch from migrate-pyproject-prepare to main March 1, 2026 18:47
@danieljanes danieljanes changed the base branch from main to migrate-pyproject-prepare March 1, 2026 19:40
Base automatically changed from migrate-pyproject-prepare to main March 2, 2026 09:42
@panh99 panh99 marked this pull request as ready for review March 2, 2026 10:25
panh99
panh99 previously approved these changes Mar 2, 2026
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes enabled auto-merge (squash) March 2, 2026 10:39
@danieljanes danieljanes merged commit f5cc60e into main Mar 2, 2026
73 checks passed
@danieljanes danieljanes deleted the migrate-devtool-py-scripts branch March 2, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants