Remove stale commented FAB ID warning in client app loader#6870
Open
danieljanes wants to merge 2 commits intomainfrom
Open
Remove stale commented FAB ID warning in client app loader#6870danieljanes wants to merge 2 commits intomainfrom
danieljanes wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a stale, commented-out warning log in the ClientApp loader (get_load_client_app_fn) to avoid misleading readers about current FAB metadata validation behavior.
Changes:
- Deleted an outdated commented
log(WARN, ...)line in the multi-app +app_pathbranch. - No runtime behavior changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
Maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
get_load_client_app_fnbecause this branch validates FAB metadata and the old comment no longer reflects runtime behavior.Description
log(WARN, "FAB ID is not provided; the default ClientApp will be loaded.")line inframework/py/flwr/clientapp/utils.pywith no functional changes to loading logic.Testing
Codex Task