Skip to content

update windows ci to 2025 version #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025
Merged

Conversation

Doublonmousse
Copy link
Collaborator

@Doublonmousse Doublonmousse commented May 8, 2025

  • update windows to 2025 version
  • install inno (done manually as this isn't part of the image otherwise)
  • set cli=true for window ci (fails otherwise, because refers to a cargo_build target only defined if the cli is set to true)

This makes it possible to use the 2025 version for compiling on the CI.

TODO

  • fix the inno version (set to a specific version)
  • checksum and validation (checksum on the exe + verify signature before launching)
  • changing how the cli parameter is setup ?
  • check dlls (missing libcrypto-3-x64.dll and libssl-3-x64.dll ?)

- update windows to 2025 version
- install inno
- set `cli=true` for window ci (fails otherwise)
@Doublonmousse
Copy link
Collaborator Author

This may be also related to issue #1418 (so maybe using a more recent windows image fixes it ?)

@Doublonmousse
Copy link
Collaborator Author

The CI was successful (https://github.com/Doublonmousse/rnote/actions/runs/15075694294) so I think this is ready for review

@Doublonmousse Doublonmousse marked this pull request as ready for review May 16, 2025 19:46
@Doublonmousse Doublonmousse marked this pull request as draft May 17, 2025 11:02
@Doublonmousse Doublonmousse marked this pull request as ready for review May 17, 2025 13:22
@Doublonmousse
Copy link
Collaborator Author

From #1436 (comment)

Note: the provided installer was missing the libraries libcrypto-3-x64.dll and libssl-3-x64.dll which I simply copied and pasted from the latest release to make it work

so it may not be working for windows 10

@Intranox
Copy link

so it may not be working for windows 10

In this case I used windows 11 24H2

@flxzt
Copy link
Owner

flxzt commented May 30, 2025

looks good to me, enabling the CLI for windows sounds like a reasonable thing to do. Is this ready to be merged?

@Doublonmousse
Copy link
Collaborator Author

From #1436 (comment)

Note: the provided installer was missing the libraries libcrypto-3-x64.dll and libssl-3-x64.dll which I simply copied and pasted from the latest release to make it work

so it may not be working for windows 10

looks good to me, enabling the CLI for windows sounds like a reasonable thing to do. Is this ready to be merged?

I'd want to wait/nack this until I'm sure it's working for @Intranox (just need to find some time to look at the dlls part)

@Doublonmousse Doublonmousse marked this pull request as draft May 30, 2025 17:14
Add missing libcrypto-3-x64.dll and libssl-3-x64.dll
@Doublonmousse
Copy link
Collaborator Author

Doublonmousse commented May 30, 2025

Running a new CI run here : https://github.com/Doublonmousse/rnote/actions/runs/15354717368
Locally this works (no missing dlls) but I might have to add a

pacman -S mingw-w64-x86_64-openssl

if this doesn't pass on CI.

Edit : this passed and I can see the dll in the build logs

@Intranox
Copy link

Edit : this passed and I can see the dll in the build logs

I confirm that it works

@Doublonmousse Doublonmousse marked this pull request as ready for review May 30, 2025 22:18
@Doublonmousse Doublonmousse added the dev Development / Build issues label Jun 8, 2025
@flxzt
Copy link
Owner

flxzt commented Jun 10, 2025

looks good, thank you!

@flxzt flxzt merged commit c6f6b20 into flxzt:main Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Development / Build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants