-
-
Notifications
You must be signed in to change notification settings - Fork 369
update windows ci to 2025 version #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- update windows to 2025 version - install inno - set `cli=true` for window ci (fails otherwise)
This may be also related to issue #1418 (so maybe using a more recent windows image fixes it ?) |
The CI was successful (https://github.com/Doublonmousse/rnote/actions/runs/15075694294) so I think this is ready for review |
From #1436 (comment)
so it may not be working for windows 10 |
In this case I used windows 11 24H2 |
looks good to me, enabling the CLI for windows sounds like a reasonable thing to do. Is this ready to be merged? |
I'd want to wait/nack this until I'm sure it's working for @Intranox (just need to find some time to look at the dlls part) |
Add missing libcrypto-3-x64.dll and libssl-3-x64.dll
Running a new CI run here : https://github.com/Doublonmousse/rnote/actions/runs/15354717368
if this doesn't pass on CI. Edit : this passed and I can see the dll in the build logs |
I confirm that it works |
looks good, thank you! |
cli=true
for window ci (fails otherwise, because refers to acargo_build
target only defined if the cli is set to true)This makes it possible to use the 2025 version for compiling on the CI.
TODO