WIP: [Feature] Setting to enable automatic background color/pattern inversion for each document #1456
+32
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to at least partially address #1293, specifically the dynamic dark-mode background (I'm thinking the stroke + palette inversion action might be its own feature)
Submitting early as WIP to open things up for discussion/feedback.
Here's a rough overview of where I'm at for anyone to follow along.
Initial approach:
background_pattern_invert_color_row
with a multi-select option:Problem(s):
Revised approach (we are here, presently):
background_pattern_invert_color_row
togeneral_background_invert_mode_row
under the general category as a more universal settingProblem(s):
I think what could make sense (if a little convoluted) could be some kind of hybrid between the local per-document setting and the global default where the local setting overrides the global default, but I'll keep considering more satisfactory ways to handle this.
I'm open to any direction or feedback.