Fixup: pin gtk4/cairo/gettext version to work on windows #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The windows CI started to fail because `inno` has been added to the image. And the `winget install` of an already installed application will fail. So - test if inno is already installed - If so do nothing - Else install it This way the code will work wherever inno is in the image or not
…ed-cases` patch Fixes Regression: rnote 13.x crashes when opening the attached file as opposed to rnote 12.x which opens the file fine. Fixes flxzt#1536 Revert "fix: compile msys without `DWrite-Get-glyph-bitmap-with-D2D-in-selected-cases` patch" This reverts commit 9cac24a. list all dependencies used before the DLLmain gettext change pin gtk4/cairo/gettext to non problematic issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Windows build here : https://github.com/Doublonmousse/rnote/actions/runs/20622694223
Now here is where it gets complicated
Technically, all versions affected by the gettext change are here msys2/MINGW-packages@83eed71
But because later version do not rely on the symbol being there, we don't have to pin all dependencies in the list (I've left them in version_packages.md but will probably remove this file later)
And because for some reason the gtk4 4.20 version has issues on windows with black borders if dcomp is activated (and other fun issues), the gtk4 4.20 version on mingw disables this. But for some reason it also completely breaks rendering in rnote (and we're back to pink rectangles and seemingly software rendering with poor framerates) so I'm pinning both gtk4 and libadwaita to 4.18 (and the corresponding libadwaita releases).