Skip to content

wrap shapeconfig_popover in a paged popover - #1809

Draft
Doublonmousse wants to merge 7 commits into
flxzt:mainfrom
Doublonmousse:paged_popover
Draft

wrap shapeconfig_popover in a paged popover#1809
Doublonmousse wants to merge 7 commits into
flxzt:mainfrom
Doublonmousse:paged_popover

Conversation

@Doublonmousse

Copy link
Copy Markdown
Collaborator

Follow up on #1524 with option 2 : paged popover

image image

Fixes #1504.

Sister PR to #1808 (where option 1 : use a scrolled window was used instead)

@Doublonmousse Doublonmousse changed the title Paged popover wrap shapeconfig_popover in a paged popover Jul 23, 2026
@flxzt

flxzt commented Jul 26, 2026

Copy link
Copy Markdown
Owner

I personally prefer this over the scrolled solution.
I am wondering if a more fitting UI pattern to use would be the view switcher: https://developer.gnome.org/hig/patterns/nav/view-switchers.html

@Doublonmousse

Copy link
Copy Markdown
Collaborator Author

Yeah, you're right, let's use the view switcher (instead of my custom thing, we'll also get more accessibility/tab support this way as well).

I'll probably not take a look at that very quickly (probably not next week) so if you want to take it on, feel free to do so

@anesthetice

Copy link
Copy Markdown
Contributor

I prefer the other solution (using a scrollable window), as I feel that it is less finicky than having to switch between popover pages.

For instance in tablet mode, it's easier to simply swipe your finger over the entire popover to scroll down rather than having to press a specific button. Moreover, currently the scroll approach doesn't even require a swipe gesture for nearly all users as the popover only becomes scrollable once its height is larger than the number of pixels available.

Also, this could probably be at least partially fixed by having a set desired width, but currently on my machine at least, when switching back to the first page, the size of the popover "pops back" after a short delay...

popping.mp4

@Doublonmousse

Copy link
Copy Markdown
Collaborator Author

Switched to a view switcher where the two pages are kept in sync as far as vertical space is concerned.

For now the name of the pages and icons are uninspired (maybe Highlighting and constraints for the second, that does come with a larger width however, maybe a better icon/name combination would be prefered). The resulting popover is also less tall because of reporting the title into the view switcher

image

In debug it does weird things as far as theming goes (had to change the syntax because of #1524 (comment) that I did encounter before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shape Tool settings not opening in Windows after building from MSYS2

3 participants