wrap shapeconfig_popover in a paged popover - #1809
Conversation
Co-authored-by: Doublonmousse <115779707+Doublonmousse@users.noreply.github.com>
So that we always have the two buttons, but with one disabled.
shapeconfig_popover in a paged popover
|
I personally prefer this over the scrolled solution. |
|
Yeah, you're right, let's use the view switcher (instead of my custom thing, we'll also get more accessibility/tab support this way as well). I'll probably not take a look at that very quickly (probably not next week) so if you want to take it on, feel free to do so |
|
I prefer the other solution (using a scrollable window), as I feel that it is less finicky than having to switch between popover pages. For instance in tablet mode, it's easier to simply swipe your finger over the entire popover to scroll down rather than having to press a specific button. Moreover, currently the scroll approach doesn't even require a swipe gesture for nearly all users as the popover only becomes scrollable once its height is larger than the number of pixels available. Also, this could probably be at least partially fixed by having a set desired width, but currently on my machine at least, when switching back to the first page, the size of the popover "pops back" after a short delay... popping.mp4 |
|
Switched to a view switcher where the two pages are kept in sync as far as vertical space is concerned. For now the name of the pages and icons are uninspired (maybe
In debug it does weird things as far as theming goes (had to change the syntax because of #1524 (comment) that I did encounter before) |

Follow up on #1524 with option 2 : paged popover
Fixes #1504.
Sister PR to #1808 (where option 1 : use a scrolled window was used instead)