Skip to content

fix: Prevent nil pointer panic in monitor loop #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Attacktive wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Prevent nil pointer panic in monitor loop #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2651383
refactor: improve error handling
Attacktive Dec 30, 2025
b8fac94
Merge branch 'fly-apps:main' into main
Attacktive Jan 17, 2026
14b12ac
chore: remove redundant error logging
Attacktive Jan 17, 2026
16677b4
chore: add error logging
Attacktive Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/cron/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,19 @@ func evaluateJob(ctx context.Context, logger *logrus.Logger, store *Store, job J
if err := store.FailJob(ctx, job.ID, -1, "machine destroyed before we could interpret the results"); err != nil {
log.WithError(err).Errorf("failed to update job %d status", job.ID)
}
return nil
} else {
log.WithError(err).Errorf("failed to get machine %s", job.MachineID.String)
}
} else {
log.WithError(err).Errorf("failed to get machine %s: %v", job.MachineID.String, err)
Copy link
Author

@Attacktive Attacktive Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if it deliberately proceeds in non-404 cases, so let me know if it does. 🙂

}

return nil
}

if machine == nil {
log.Errorf("job %d has a nil machine %s", job.ID, job.MachineID.String)
return nil
}

log.Debugf("Monitoring job")
Expand Down