Install only production dependencies using Bun#151
Merged
rubys merged 1 commit intofly-apps:mainfrom Jun 29, 2025
Merged
Conversation
This could be extended to the other major JS providers too, but that might be out of scope for this.
Contributor
|
Cool! Possibly related: oven-sh/bun#3605 |
Contributor
Author
|
Oh, interesting! I wonder which is the more useful way around in this case 🤔 |
Contributor
Author
|
I'm not clear what's actually failing in these tests. The postgres tests seem unrelated? |
Contributor
|
Note that that issue is still unresolved. The desire is that the end result is that only production dependencies are installed in the final image. I'm fine if the way to achieve that result varies by packaging tool. In fact, it seems necessarily so. As to Postgres, it looks like Rails recently changed and the test case simply needs to be updated to match: rails/rails@de9dd40 ; that need not hold up this pull request. |
Contributor
Author
|
I'm happy to add some other packaging tools as part of this PR whilst I'm at it if you'd like? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be extended to the other major JS providers too, but that
might be out of scope for this.