Move to bufio reader to support larger tokens #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immerrr
reviewed
Feb 3, 2025
internal/supervisor/output.go
Outdated
Comment on lines
60
to
68
| line, err := reader.ReadBytes('\n') | ||
| if err != nil { | ||
| // EOF is expected, so don't log it | ||
| if err != io.EOF { | ||
| log.Printf("reader error: %v", err) | ||
| } | ||
| break | ||
| } | ||
| m.WriteLine(proc, line) |
There was a problem hiding this comment.
According to the docs, line may be non-empty even in case of an error (e.g. if the last output line is not terminated by \n), so may be worth piping it through regardless:
Suggested change
| line, err := reader.ReadBytes('\n') | |
| if err != nil { | |
| // EOF is expected, so don't log it | |
| if err != io.EOF { | |
| log.Printf("reader error: %v", err) | |
| } | |
| break | |
| } | |
| m.WriteLine(proc, line) | |
| line, err := reader.ReadBytes('\n') | |
| if len(line) > 0 { | |
| m.WriteLine(proc, line) | |
| } | |
| if err != nil { | |
| // EOF is expected, so don't log it | |
| if err != io.EOF { | |
| log.Printf("reader error: %v", err) | |
| } | |
| break | |
| } | |
There was a problem hiding this comment.
And one more thing, ReadBytes keeps the terminator in the returned line, so WriteLine may need to account for it:
buf.WriteString("\033[0m | ")
buf.Write(p)
- buf.WriteByte('\n')
+ if p[len(p)-1] != '\n' {
+ buf.WriteByte('\n')
+ }
m.mutex.Lock()
defer m.mutex.Unlock()
|
@immerrr Thanks for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works to address: #272