Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sound): throttle local var #9772

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

F in the sound.xml.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Check sounds work correctly for both throttle levers.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added QA Tier 1 A32NX Related to the A32NX aircraft labels Jan 17, 2025
@tracernz tracernz added this to the v0.13.0 milestone Jan 17, 2025
Copy link
Member

@hotshotp hotshotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Saschl
Copy link
Contributor

Saschl commented Jan 17, 2025

I could also find LocalVFar in the 380 files, should we also fix it in this PR?

@tracernz
Copy link
Member Author

I could also find LocalVFar in the 380 files, should we also fix it in this PR?

Can be fixed in another PR. Keeps testing simple and small.

@utkrishtm
Copy link

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9772
Aircraft : A32NX
Tier of Testing : 1
Date : 22/01/2025

Testing Process:

  • The sounds work fine for both throttles. Tested them individually to check movement sounds, detents sounds, as well as reverser engage sounds.

Testing Results:
Passed

@Saschl Saschl enabled auto-merge (squash) January 22, 2025 23:07
@Saschl Saschl merged commit 7431661 into flybywiresim:master Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants