fix(a380x): fix speed margin display above crossover altitude #9861
+47
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
reviewed
Feb 15, 2025
Comment on lines
+53
to
+61
| /** | ||
| * The maximum operating speed in knots | ||
| */ | ||
| VMO: number; | ||
|
|
||
| /** | ||
| * The maximum operating Mach number | ||
| */ | ||
| MMO: number; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * The maximum operating speed in knots | |
| */ | |
| VMO: number; | |
| /** | |
| * The maximum operating Mach number | |
| */ | |
| MMO: number; | |
| /** | |
| * The maximum operating speed in knots | |
| */ | |
| Vmo: number; | |
| /** | |
| * The maximum operating Mach number | |
| */ | |
| Mmo: number; |
Our current style.
-e- hmm, well the rest of it is for some reason upper-snake-case? 😕 That wasn't ever FBW style.
There was a problem hiding this comment.
Do we have this convention written down somewhere? I also prefer PascalCase for these parameters that do not change at runtime, but it does not appear that this has been enforced so far.
There was a problem hiding this comment.
We should probably write them down, yeah.
There was a problem hiding this comment.
I have opened a separate PR to convert them #9865. It would be ideal to have a lint rule for this, but I have not found one that does this.
tracernz
approved these changes
Feb 15, 2025
BlueberryKing
force-pushed
the
fix-a380x-speed-margins
branch
from
c432c24 to
fc706d3
Compare
BlueberryKing
force-pushed
the
fix-a380x-speed-margins
branch
from
fc706d3 to
0c16431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
The speed margins are upper-limited by VMO and MMO. Previously these values were hardcoded to the A320 values (350 kts and M.82). This PR makes them configurable per aircraft type.
Screenshots (if necessary)
Before:
After:
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.