feat: move images to new bot repo #92
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge label added as DB changes must be made simultaneously |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in Progress:
Image calculation:
51 Commands currently have images. - https://gist.github.com/benw202/6db3e23ca73479869ab64e7cd4f88d8b
53 Images Exist
boris.gif - command for this image is currently empty
nut-2.png - is legacy
pov.gif - we are using the downscaled version
sop.png - is unused
screenshot.png - needs to be changed to combined-screenshot.png - Spelling needs changing in DB (extra
-h)hud - don't use CDN - Will need changing in DB
pfctest - don't use CDN - Will need changing in DB
55 Images will exist when HUD and pfctest are uploaded.
4 Unused images, leaves us with 51 images in 51 commands.
This PR moves all images from the old bot repo to the new bot repo. Images under A32nx have now been put into a generic Aircraft folder. It is undecided if the Aircraft directory should be further split to A32nx, A380x and general.
Changes need to be made in the database to accommodate this. One change to change the base URL from
https://assets.discord.flybywirecdn.com/assets/images/...tohttps://assets.discord.flybywirecdn.com/utils/assets/images/prefix/.... And one to change any image URL including thea32nxdirectory to theaircraftdirectory. I have scripts prepared which need to be run when this PR is merged (Production and Staging). See an example of the change below:Original URL:
https://assets.discord.flybywirecdn.com/assets/images/a32nx/screens.pngNew URL:
https://assets.discord.flybywirecdn.com/utils/assets/images/prefix/aircraft/screens.pngThis PR also updates the profile picture of the production bot
Test Results
N/A
Discord Username
benw8484