PL-135522: log HTTPException errors at ERROR level before returning response#36
Merged
Merged
Conversation
afe1061 to
886f784
Compare
Also, document why we're going down this route.
886f784 to
eb52b2e
Compare
elikoga
commented
Jun 22, 2026
eb52b2e to
68c5294
Compare
ctheune
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PL-135522
Removing a model from inference but not the gateway makes the system 500 forever.
The update_manifest handler raises HTTPException(500) when the gateway requests models the inference server doesn't know about. FastAPI's built-in handler catches this before the custom @app.exception_handler(Exception) gets it, so the error detail was silently swallowed -- only visible in the bare status code in access.log.
Fix: