Skip to content

Conversation

@DanielSmedegaardBuus
Copy link
Contributor

I put the fixes in first, and I'm working on the custom user commands thing, so it's undocumented right now. I put an example in user-extension.js, doTypeRedactor.

Note: All the keyEvent commands, focus, and the example custom command do NOT work with the NPM version of node-wd-sync. This is because sebv is automatically wrapping all elements returned by wd in "synchronize magic" code, which makes the elements incompatible with wd's .execute methods. I created a pull request with a work-around, but I'm not sure how active sebv is anymore — his last change was two years ago.... If he doesn't respond soon, I'll probably create an NPM of my own :)

About the previous change in

if (this.message.match(/^(getEval|runScript)/))
        adaptor.rawArgs = this.args; // getEval only args available (Daniel: I assume this means we always want escaped stringified args here; that is, the code as converted to a string, for use with browser.safeEval(<code string>), and getEval may be used elsewhere, so we still want to have that pass forth unescaped rawArgs by default...?)

... I actually can't remember what I meant by that note, but you seem to know what the deal is :D Could you fix that?

Thanks!! :)

... prepping for extensible commands stuf ...

Signed-off-by: Daniel Smedegaard Buus <[email protected]>
Signed-off-by: Daniel Smedegaard Buus <[email protected]>
* fixed: keyEvent event type argument wasn't quoted
* workaround/fix [REQUIRES PULL REQUEST #30 ON node-wd-sync TO WORK!]: elements returned by wd-sync'ified wd methods are incompatible with .execute[Async] due to make-sync code mangling.

Signed-off-by: Daniel Smedegaard Buus <[email protected]>
WIP, needs work :)

Signed-off-by: Daniel Smedegaard Buus <[email protected]>
Signed-off-by: Daniel Smedegaard Buus <[email protected]>
@DanielSmedegaardBuus
Copy link
Contributor Author

AFAICT, the conflict is the lbParam argument — I put that back in the last commit 👍 :)

@flyingfisher flyingfisher merged commit 6edad1c into flyingfisher:master Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants