Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USE_HOST_X options #1846

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brosasaki
Copy link
Contributor

No description provided.

@flyinghead
Copy link
Owner

I don't understand what is the point of these changes:
vulkan-headers, xxhash, glm and vulkan-memory_allocator are headers-only libraries. So using the host/OS version will not reduce resource usage, will not decrease the executable size and won't allow for easy security updates. It's only adding complexity to the build process and increasing the likelihood of a build failure.
Google-test is only used when building and running tests, and isn't part of the final flycast executable. So again, using the host/OS version won't make it easier to package the app.

@brosasaki
Copy link
Contributor Author

TBH, I just poked around and did the ones that were trivial. I’ll do more significant ones soon.

@flyinghead
Copy link
Owner

Please limit the changes to what is strictly necessary. The build process is already far too complicated for my taste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants