-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden serial comm interface #1847
Merged
flyinghead
merged 26 commits into
flyinghead:dev
from
Tails86:harden-serial-comm-interface
Feb 16, 2025
Merged
Harden serial comm interface #1847
flyinghead
merged 26 commits into
flyinghead:dev
from
Tails86:harden-serial-comm-interface
Feb 16, 2025
+628
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fully compatible with DreamPort v0.999 and is compatible with older versions of DreamPort in host-1p mode.
tearDownDreamConnDevices()
MapleDevices
to usesmart_ptr
@kosekmi helped me to test these changes. He reports they work on all OS, but we have a few minor bugs to work out in the future.
There are also a few things I'd like to clean up with future PRs:
TYPE_DREAMCONN
andTYPE_DREAMPORT
macrosDreamConnVmu
andDreamConnPurupuru
- the way it's swapping out what was already there. Seems like something should be injected into maple_cfg to allow the controller to dictate what gets created, but I don't feel confident with this code yet to say with much conviction._unique_id
of the SDLGamepad can be adjusted to serial and known letter of a DreamPort device to overcome the weird randomness of WindowsThank you for allowing us to contribute to this project. It has been a great experience, and I love this emulator now 😄